Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1619414

[PATCH 1/4] Input: db9 - use setup_timer

Path csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From Geliang Tang <geliangtang@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 1/4] Input: db9 - use setup_timer
Date Sun, 09 Apr 2017 03:40:01 +0200
Message-ID <tu9ZD-4FS-5@gated-at.bofh.it> (permalink)
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=B67tqktxC8UjS3+c+DAf3bRYAxNjBzq+EMsov5/8V9k=; b=b+Avu/Vs2Xb/17Bf+YvuCB0rZtbchDeAeo/yYdlxCOqrB2U1Xq0mk3nOjJ1ahCjf+n WKt4lpAHirnP/+EupF2RM51M7B/ZSZz6Fhx1tweR0eUdBxduUZ+VYHYq7TaTe/dxqhKC uo6sTBpwZX4ipBkkvY6EB9fujX0dKzwTeIs3G8mOKE72O/2l/u2HVqqVDGFd8WvLibwq S95h97p2kCLDLFyxpQSSOoNvBXFknQNRJ/tYAedEGaFxucqcWrBbTX0OzcKbBLaGDA0f KXnGBJ959qUumBemNmRsV4tXAiWxZMH+pN7TA+U3+w9PzC0Dr/jV9WgsHJEQa8IA9NHb VoZA==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=B67tqktxC8UjS3+c+DAf3bRYAxNjBzq+EMsov5/8V9k=; b=Rd6JqEN3B+C61x42d1etpzLd6ibnsGOoPLWErzyKfSPIu084NX5K3ra2sFJwdAGw8q IijFb+nVzqq1DSvxqv0007TcvVEUVyt8QN5D2uTrHm2Sf98akv2deRiIp5o/JWFuxTK/ vSitn61Vi0otDh77OPmoMdhobLWmpqZ2ejTUrC5D95kv4mTlx6xE88H+KfqnucxLKhMF 81QfcH0JmrJTy+vIQL046D5Nq2GMu2S/epCUYzyB8YZB5+o75SMqmSHXRYs4XJYO9Aoe GLTuOAdVACpl5TzionwyTwaBZ99U46LBzxSgef++EuNvpkKrwZD2CcwUSJMagR65uLlQ OgnA==
X-Gm-Message-State AN3rC/5lJMltE2/x5MY8qrf7zzlU1hMvK2f89P/F/91kweVoM4WwlALRX90QRD/SLCc7TA==
X-Received by 10.84.238.198 with SMTP id l6mr5528157pln.95.1491701985578; Sat, 08 Apr 2017 18:39:45 -0700 (PDT)
X-Mailer git-send-email 2.9.3
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 24
Organization linux.* mail to news gateway
X-Original-Cc Geliang Tang <geliangtang@gmail.com>, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Sun, 9 Apr 2017 09:39:35 +0800
X-Original-Message-ID <f1804ee67d021aa15a44a5e62ed5277c2eab50b5.1490951519.git.geliangtang@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1619414

Show key headers only | View raw


Use setup_timer() instead of init_timer() to simplify the code.

Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
 drivers/input/joystick/db9.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/input/joystick/db9.c b/drivers/input/joystick/db9.c
index da32609..f4ad83e 100644
--- a/drivers/input/joystick/db9.c
+++ b/drivers/input/joystick/db9.c
@@ -609,9 +609,7 @@ static void db9_attach(struct parport *pp)
 	db9->pd = pd;
 	db9->mode = mode;
 	db9->parportno = pp->number;
-	init_timer(&db9->timer);
-	db9->timer.data = (long) db9;
-	db9->timer.function = db9_timer;
+	setup_timer(&db9->timer, db9_timer, (long)db9);
 
 	for (i = 0; i < (min(db9_mode->n_pads, DB9_MAX_DEVICES)); i++) {
 
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/4] Input: db9 - use setup_timer Geliang Tang <geliangtang@gmail.com> - 2017-04-09 03:40 +0200
  [PATCH 4/4] Input: turbografx - use setup_timer Geliang Tang <geliangtang@gmail.com> - 2017-04-09 03:50 +0200
  [PATCH 3/4] Input: locomokbd - use setup_timer Geliang Tang <geliangtang@gmail.com> - 2017-04-09 03:50 +0200
  [PATCH 2/4] Input: gameport - use setup_timer Geliang Tang <geliangtang@gmail.com> - 2017-04-09 03:50 +0200

csiph-web