Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1619432

[PATCH 3/4] Input: locomokbd - use setup_timer

From Geliang Tang <geliangtang@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 3/4] Input: locomokbd - use setup_timer
Date 2017-04-09 03:50 +0200
Message-ID <tua9k-4Jh-13@gated-at.bofh.it> (permalink)
References <tu9ZD-4FS-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Use setup_timer() instead of init_timer() to simplify the code.

Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
 drivers/input/keyboard/locomokbd.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/input/keyboard/locomokbd.c b/drivers/input/keyboard/locomokbd.c
index c94d610..0d74312d 100644
--- a/drivers/input/keyboard/locomokbd.c
+++ b/drivers/input/keyboard/locomokbd.c
@@ -264,9 +264,8 @@ static int locomokbd_probe(struct locomo_dev *dev)
 
 	spin_lock_init(&locomokbd->lock);
 
-	init_timer(&locomokbd->timer);
-	locomokbd->timer.function = locomokbd_timer_callback;
-	locomokbd->timer.data = (unsigned long) locomokbd;
+	setup_timer(&locomokbd->timer, locomokbd_timer_callback,
+		    (unsigned long)locomokbd);
 
 	locomokbd->suspend_jiffies = jiffies;
 
-- 
2.9.3

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/4] Input: db9 - use setup_timer Geliang Tang <geliangtang@gmail.com> - 2017-04-09 03:40 +0200
  [PATCH 4/4] Input: turbografx - use setup_timer Geliang Tang <geliangtang@gmail.com> - 2017-04-09 03:50 +0200
  [PATCH 3/4] Input: locomokbd - use setup_timer Geliang Tang <geliangtang@gmail.com> - 2017-04-09 03:50 +0200
  [PATCH 2/4] Input: gameport - use setup_timer Geliang Tang <geliangtang@gmail.com> - 2017-04-09 03:50 +0200

csiph-web