Re: [PATCH 17/24] acpi: Ignore acpi_rsdp kernel param when the kernel has been locked down

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Dave Young <dyoung@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 17/24] acpi: Ignore acpi_rsdp kernel param when the kernel has been locked down
Date	Fri, 07 Apr 2017 09:50:02 +0200
Message-ID	<ttwOC-4ar-21@gated-at.bofh.it> (permalink)
References	<ttvIS-3yA-11@gated-at.bofh.it> <tsZzj-7hF-5@gated-at.bofh.it> <tsZzk-7hF-23@gated-at.bofh.it> <ttlzQ-5bW-7@gated-at.bofh.it> <ttwbT-3XD-1@gated-at.bofh.it>
X-Original-To	David Howells <dhowells@redhat.com>
Dmarc-Filter	OpenDMARC Filter v1.3.2 mx1.redhat.com 7CCBB61B92
Authentication-Results	ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results	ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dyoung@redhat.com
Dkim-Filter	OpenDKIM Filter v2.11.0 mx1.redhat.com 7CCBB61B92
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.7.1 (2016-10-04)
X-Scanned-By	MIMEDefang 2.79 on 10.5.11.12
X-Greylist	Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 07 Apr 2017 07:40:08 +0000 (UTC)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	29
Organization	linux.* mail to news gateway
X-Original-Cc	"Rafael J. Wysocki" <rafael@kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, gnomes@lxorguk.ukuu.org.uk, linux-efi@vger.kernel.org, Josh Boyer <jwboyer@redhat.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, ACPI Devel Maling List <linux-acpi@vger.kernel.org>, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, matthew.garrett@nebula.com
X-Original-Date	Fri, 7 Apr 2017 15:39:56 +0800
X-Original-Message-ID	<20170407073956.GA10737@dhcp-128-65.nay.redhat.com>
X-Original-References	<20170407063107.GA10451@dhcp-128-65.nay.redhat.com> <149142326734.5101.4596394505987813763.stgit@warthog.procyon.org.uk> <149142341772.5101.12366553346604485034.stgit@warthog.procyon.org.uk> <CAJZ5v0j580XfGHd+GVQe+7vuSGyxFzfrDOjYfOcGTnKZSvjCoA@mail.gmail.com> <21360.1491548727@warthog.procyon.org.uk>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1618550

Show key headers only | View raw

On 04/07/17 at 08:05am, David Howells wrote:
> Dave Young <dyoung@redhat.com> wrote:
> 
> > > > This option allows userspace to pass the RSDP address to the kernel, which
> > > > makes it possible for a user to circumvent any restrictions imposed on
> > > > loading modules.  Ignore the option when the kernel is locked down.
> > > 
> > > I'm not really sure here.
> > > 
> > > What exactly is the mechanism?
> > 
> > Actually this acpi_rsdp param is created for EFI kexec reboot in old
> > days when we had not supported persistent efi vm space across kexec
> > reboot. At that time kexec reboot runs as noefi mode, it can not find
> > the acpi root table thus kernel will hang early.
> > 
> > Now kexec can support EFI boot so this param is not necessary for most
> > user unless they still use efi=old_map.
> 
> Is this patch now unnecessary?

I think it is still necessary because the acpi_rsdp kernel param is still
a valid paramater and one can still pass a pointer to be recognized as acpi
root pointer.

Maybe "imposed on loading modules" is not clear which can be dropped.

Thanks
Dave

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 17/24] acpi: Ignore acpi_rsdp kernel param when the kernel  has been locked down David Howells <dhowells@redhat.com> - 2017-04-05 22:20 +0200
  Re: [PATCH 17/24] acpi: Ignore acpi_rsdp kernel param when the kernel  has been locked down "Rafael J. Wysocki" <rafael@kernel.org> - 2017-04-06 21:50 +0200
    Re: [PATCH 17/24] acpi: Ignore acpi_rsdp kernel param when the  kernel has been locked down Dave Young <dyoung@redhat.com> - 2017-04-07 08:40 +0200
      Re: [PATCH 17/24] acpi: Ignore acpi_rsdp kernel param when the kernel has been locked down David Howells <dhowells@redhat.com> - 2017-04-07 09:10 +0200
        Re: [PATCH 17/24] acpi: Ignore acpi_rsdp kernel param when the  kernel has been locked down Dave Young <dyoung@redhat.com> - 2017-04-07 09:50 +0200

csiph-web