Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1618549

Re: [PATCH V2 11/16] block, bfq: reduce idling only in symmetric scenarios

Show all headers | View raw

> Il giorno 31 mar 2017, alle ore 17:20, Bart Van Assche <bart.vanassche@sandisk.com> ha scritto:
> 
> On Fri, 2017-03-31 at 14:47 +0200, Paolo Valente wrote:
>> +       entity->weight_counter = kzalloc(sizeof(struct bfq_weight_counter),
>> +                                        GFP_ATOMIC);
>> +       entity->weight_counter->weight = entity->weight;
> 
> GFP_ATOMIC allocations are more likely to fail than GFP_KERNEL allocations.
> What will happen if kzalloc() returns NULL?
> 

A plain crash :( I'm adding the simple handling of this forgotten exception. If I don't get other reviews in the next days, I'll post a V3 addressing this and the other issue you highlighted.

Thanks,
Paolo

> Bart.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V2 00/16] Introduce the BFQ I/O scheduler Paolo Valente <paolo.valente@linaro.org> - 2017-03-31 15:00 +0200
  [PATCH V2 05/16] block, bfq: add more fairness with writes and slow processes Paolo Valente <paolo.valente@linaro.org> - 2017-03-31 15:00 +0200
  [PATCH V2 04/16] block, bfq: modify the peak-rate estimator Paolo Valente <paolo.valente@linaro.org> - 2017-03-31 15:00 +0200
    Re: [PATCH V2 04/16] block, bfq: modify the peak-rate estimator Paolo Valente <paolo.valente@linaro.org> - 2017-04-04 12:50 +0200
      Re: [PATCH V2 04/16] block, bfq: modify the peak-rate estimator Bart Van Assche <Bart.VanAssche@sandisk.com> - 2017-04-04 17:30 +0200
        Re: [PATCH V2 04/16] block, bfq: modify the peak-rate estimator Paolo Valente <paolo.valente@linaro.org> - 2017-04-06 21:40 +0200
  [PATCH V2 11/16] block, bfq: reduce idling only in symmetric scenarios Paolo Valente <paolo.valente@linaro.org> - 2017-03-31 15:00 +0200
    Re: [PATCH V2 11/16] block, bfq: reduce idling only in symmetric scenarios Paolo Valente <paolo.valente@linaro.org> - 2017-04-07 09:50 +0200
  [PATCH V2 09/16] block, bfq: reduce latency during request-pool saturation Paolo Valente <paolo.valente@linaro.org> - 2017-03-31 15:00 +0200
  [PATCH V2 13/16] block, bfq: boost the throughput with random I/O on NCQ-capable HDDs Paolo Valente <paolo.valente@linaro.org> - 2017-03-31 15:00 +0200
  [PATCH V2 07/16] block, bfq: reduce I/O latency for soft real-time applications Paolo Valente <paolo.valente@linaro.org> - 2017-03-31 15:00 +0200
  [PATCH V2 15/16] block, bfq: remove all get and put of I/O contexts Paolo Valente <paolo.valente@linaro.org> - 2017-03-31 15:00 +0200

csiph-web