Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1618495

Re: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation

Show all headers | View raw

On Mon, Apr 3, 2017 at 11:16 PM, Matt Ranostay
<matt.ranostay@konsulko.com> wrote:
> On Sun, Apr 2, 2017 at 10:29 AM, Andreas Klinger <ak@it-klinger.de> wrote:
>> Linus Walleij <linus.walleij@linaro.org> schrieb am Sun, 02. Apr 16:56:
>>> On Sun, Apr 2, 2017 at 11:32 AM, Jonathan Cameron <jic23@kernel.org> wrote:
>>> > On 27/03/17 11:06, Andreas Klinger wrote:
>>> >> While calculating the compensation of the humidity there are negative
>>> >> values interpreted as unsigned because of unsigned variables used.
>>> >> These values need to be casted to signed as indicated by the documentation
>>> >> of the sensor.
>>> >>
>>> >> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
>>> >
>>> > Looks superficially right to me, but would like an Ack from Linus Walleij.
>>>
>>> I didn't work on these calculations, only infrastructure for the driver
>>> but FWIW:
>>> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>>>
>>> Matt Ranostay @Intel is the person you probably want to ACK it though,
>>> he added the humidity calculations :)
>>
>> It just turned out that there must be another error in the calculation. I'll fix
>> and test it first.
>>
>> When i'm done i'll send a new version of the patch.
>>
>
> Ok will hold off till review till the next patchset... BTW this
> datasheet's calculations made my eyes bleed so it is quiet likely it
> has bugs...

Hmm the datatypes you are casting to s32 are already signed
integers...  Interested in what you found on what the actual bug is.

>
> Thanks,
>
> Matt
>
>> Andreas
>>
>>>
>>> Yours,
>>> Linus Walleij
>>
>> --
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation Jonathan Cameron <jic23@kernel.org> - 2017-04-02 11:40 +0200
  Re: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation Linus Walleij <linus.walleij@linaro.org> - 2017-04-02 17:00 +0200
    Re: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation Andreas Klinger <ak@it-klinger.de> - 2017-04-02 19:40 +0200
      Re: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation Jonathan Cameron <jic23@jic23.retrosnub.co.uk> - 2017-04-02 19:50 +0200
      Re: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation Matt Ranostay <matt.ranostay@konsulko.com> - 2017-04-04 08:20 +0200
        Re: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation Matt Ranostay <matt.ranostay@konsulko.com> - 2017-04-07 08:20 +0200
          Re: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation Andreas Klinger <ak@it-klinger.de> - 2017-04-07 21:30 +0200
            Re: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation Matt Ranostay <matt.ranostay@konsulko.com> - 2017-04-08 23:40 +0200

csiph-web