Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1614754
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation |
| Date | 2017-04-02 17:00 +0200 |
| Message-ID | <trP8Z-1O4-3@gated-at.bofh.it> (permalink) |
| References | <tpzL5-6pP-41@gated-at.bofh.it> <trK9k-74G-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sun, Apr 2, 2017 at 11:32 AM, Jonathan Cameron <jic23@kernel.org> wrote: > On 27/03/17 11:06, Andreas Klinger wrote: >> While calculating the compensation of the humidity there are negative >> values interpreted as unsigned because of unsigned variables used. >> These values need to be casted to signed as indicated by the documentation >> of the sensor. >> >> Signed-off-by: Andreas Klinger <ak@it-klinger.de> > > Looks superficially right to me, but would like an Ack from Linus Walleij. I didn't work on these calculations, only infrastructure for the driver but FWIW: Acked-by: Linus Walleij <linus.walleij@linaro.org> Matt Ranostay @Intel is the person you probably want to ACK it though, he added the humidity calculations :) Yours, Linus Walleij
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation Jonathan Cameron <jic23@kernel.org> - 2017-04-02 11:40 +0200
Re: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation Linus Walleij <linus.walleij@linaro.org> - 2017-04-02 17:00 +0200
Re: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation Andreas Klinger <ak@it-klinger.de> - 2017-04-02 19:40 +0200
Re: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation Jonathan Cameron <jic23@jic23.retrosnub.co.uk> - 2017-04-02 19:50 +0200
Re: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation Matt Ranostay <matt.ranostay@konsulko.com> - 2017-04-04 08:20 +0200
Re: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation Matt Ranostay <matt.ranostay@konsulko.com> - 2017-04-07 08:20 +0200
Re: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation Andreas Klinger <ak@it-klinger.de> - 2017-04-07 21:30 +0200
Re: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation Matt Ranostay <matt.ranostay@konsulko.com> - 2017-04-08 23:40 +0200
csiph-web