Re: [PATCH] net: davinci_mdio: add GPIO reset logic

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Roger Quadros <rogerq@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: davinci_mdio: add GPIO reset logic
Date	Thu, 06 Apr 2017 18:50:02 +0200
Message-ID	<ttiLE-3md-35@gated-at.bofh.it> (permalink)
References	<tsODU-f3-17@gated-at.bofh.it> <tsUJk-4eA-17@gated-at.bofh.it> <ttbTP-6GC-3@gated-at.bofh.it> <tteoF-8jD-13@gated-at.bofh.it>
X-Original-To	Andrew Lunn <andrew@lunn.ch>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1491497334; bh=GDk2pC8wFFjCoF7MMrqhNQGIG3u0A+5Es7oS7KKGl9Y=; h=Subject:To:References:CC:From:Date:In-Reply-To; b=Ekcr3DICPtTyvQa8hjBma6gn8gwT1RpRW8O9gL+Ry1oQFHZFnld7R6QE8Q2BRHU0O t0UcLJimy+wCaG+8OTwf23RrOKWe3O7/3Wi2h+TpFGgBzoLqvESz/OAvWGiPpokeEe Y1EuCtri1xFg1/gFivjnljiZ+2RCAQ1+sWlD+ULY=
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
MIME-Version	1.0
Content-Type	text/plain; charset="windows-1252"
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	24
Organization	linux.* mail to news gateway
X-Original-Cc	<davem@davemloft.net>, <tony@atomide.com>, <nsekhar@ti.com>, <jsarha@ti.com>, <netdev@vger.kernel.org>, <linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>
X-Original-Date	Thu, 6 Apr 2017 19:48:50 +0300
X-Original-Message-ID	<4611f957-4de2-ccf6-c9e6-1ace1f3f8ac3@ti.com>
X-Original-References	<1491381237-24635-1-git-send-email-rogerq@ti.com> <20170405150334.GI13449@lunn.ch> <485433e3-1a9f-71f6-afc9-88e646cf43d1@ti.com> <20170406120532.GC13219@lunn.ch>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1618183

Show key headers only | View raw

On 06/04/17 15:05, Andrew Lunn wrote:
>>> Do you really need more than one GPIO? A single gpio would make all
>>> this code a lot simpler.
>>>
>>
>> Yes we need. Some of our boards have separate GPIO RESET lines for
>> different PHYs on the same MDIO bus.
> 
> If you have a one-to-one mapping of GPIO and PHY, you should really be
> modelling that differently. You want to be able to reset just a single
> PHY, i.e. make it part of the PHY driver, or maybe the PHY core.
> 
>      Andrew
> 

I'm not sure how it would be modelled. We have never had the need to reset
just one PHY on the MDIO bus.
Some boards have a single RESET line to multiple PHYs whereas others have individual
RESET lines. In all cases we just want to do the RESET once per boot.

cheers,
-roger

Thread

[PATCH] net: davinci_mdio: add GPIO reset logic Roger Quadros <rogerq@ti.com> - 2017-04-05 10:40 +0200
  Re: [PATCH] net: davinci_mdio: add GPIO reset logic Andrew Lunn <andrew@lunn.ch> - 2017-04-05 17:10 +0200
    Re: [PATCH] net: davinci_mdio: add GPIO reset logic Roger Quadros <rogerq@ti.com> - 2017-04-06 11:30 +0200
      Re: [PATCH] net: davinci_mdio: add GPIO reset logic Andrew Lunn <andrew@lunn.ch> - 2017-04-06 14:10 +0200
        Re: [PATCH] net: davinci_mdio: add GPIO reset logic Roger Quadros <rogerq@ti.com> - 2017-04-06 18:50 +0200
  Re: [PATCH] net: davinci_mdio: add GPIO reset logic David Miller <davem@davemloft.net> - 2017-04-08 16:00 +0200
    Re: [PATCH] net: davinci_mdio: add GPIO reset logic Andrew Lunn <andrew@lunn.ch> - 2017-04-08 17:20 +0200
      Re: [PATCH] net: davinci_mdio: add GPIO reset logic Florian Fainelli <f.fainelli@gmail.com> - 2017-04-08 17:20 +0200
        Re: [PATCH] net: davinci_mdio: add GPIO reset logic Roger Quadros <rogerq@ti.com> - 2017-04-10 10:00 +0200

csiph-web