Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1619011

Re: [PATCH v2 00/11] fujitsu-laptop: backlight cleanup

Show all headers | View raw

On Fri, Apr 07, 2017 at 09:41:35PM +0930, Jonathan Woithe wrote:
> On Wed, Apr 05, 2017 at 08:07:54PM -0700, Darren Hart wrote:
> > On Thu, Apr 06, 2017 at 10:15:14AM +0930, Jonathan Woithe wrote:
> > > On Wed, Apr 05, 2017 at 09:55:34PM +0200, Micha?? K??pie?? wrote:
> > > > > On Wed, Apr 05, 2017 at 08:48:59AM +0200, Micha?? K??pie?? wrote:
> > > > > > This series introduces further changes to the way LCD backlight is
> > > > > > handled by fujitsu-laptop.  These changes include fixing a bug in code
> > > > > > responsible for generating brightness-related input events, cleaning up
> > > > > > handling of module parameters, reducing code duplication, removing
> > > > > > superfluous debug messages and other fixes.
> > > > > > 
> > > > > > This series was tested on a Lifebook S7020 and a Lifebook E744.
> > > > > > 
> > > > > > This series is based on the testing branch as it requires earlier patch
> > > > > > series I submitted in order to apply cleanly.
> > > > > > 
> > > > > > Changes from v1:
> > > > > > 
> > > > > >   - Update debug message logged by set_lcd_level() to reflect code flow
> > > > > >     changes introduced by patch 04/11.
> > > > > 
> > > > > Queued to testing, thanks! 
> > > > 
> > > > Jonathan, I would still love to hear your opinion on this series.  Take
> > > > your time, though, I do not see any reason to rush things.  I will only
> > > > send the next series once you ack this one.
> > > 
> > > Sure, no problem.  As mentioned earlier, this week has been busy.  I am
> > > hoping I might find the time to complete my review this evening.  If not, it
> > > will be some time over the weekend.
> > 
> > Eeek, I jumped the gun on that. I've moved this from testing to fujitsu, and
> > it'll wait there until Jonathan gets a chance to review. Apologies Jonathan.
> 
> That's fine, these things happen.
> 
> I've completed a review of this series.  It represents another worthwhile
> evolutionary clean up of the fujitsu-laptop driver, this time concentrating
> on the backlight functions.  Importantly, it makes adjustments for changes
> in related kernel infrastructure as it has evolved over the last few
> years (the handling of module parameters, method return values and so on).
> 
> I am happy for this series to be merged.  Thanks Michael for your continued
> clean up efforts.
> 
> Reviewed-by: Jonathan Woithe <jwoithe@just42.net>

Queued to testing, thanks!

-- 
Darren Hart
VMware Open Source Technology Center

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 00/11] fujitsu-laptop: backlight cleanup Michał Kępień <kernel@kempniu.pl> - 2017-04-05 08:50 +0200
  [PATCH v2 11/11] platform/x86: fujitsu-laptop: remove redundant fields from struct fujitsu_bl Michał Kępień <kernel@kempniu.pl> - 2017-04-05 08:50 +0200
  [PATCH v2 10/11] platform/x86: fujitsu-laptop: account for backlight power when determining brightness Michał Kępień <kernel@kempniu.pl> - 2017-04-05 08:50 +0200
  [PATCH v2 07/11] platform/x86: fujitsu-laptop: make disable_brightness_adjust a boolean Michał Kępień <kernel@kempniu.pl> - 2017-04-05 08:50 +0200
  [PATCH v2 08/11] platform/x86: fujitsu-laptop: ignore errors when setting backlight power Michał Kępień <kernel@kempniu.pl> - 2017-04-05 09:00 +0200
  [PATCH v2 06/11] platform/x86: fujitsu-laptop: clean up use_alt_lcd_levels handling Michał Kępień <kernel@kempniu.pl> - 2017-04-05 09:00 +0200
  [PATCH v2 02/11] platform/x86: fujitsu-laptop: switch to a managed backlight device Michał Kępień <kernel@kempniu.pl> - 2017-04-05 09:00 +0200
  [PATCH v2 04/11] platform/x86: fujitsu-laptop: simplify set_lcd_level() Michał Kępień <kernel@kempniu.pl> - 2017-04-05 09:00 +0200
  [PATCH v2 05/11] platform/x86: fujitsu-laptop: sync brightness in set_lcd_level() Michał Kępień <kernel@kempniu.pl> - 2017-04-05 09:00 +0200
  [PATCH v2 01/11] platform/x86: fujitsu-laptop: only handle backlight when appropriate Michał Kępień <kernel@kempniu.pl> - 2017-04-05 09:00 +0200
  [PATCH v2 09/11] platform/x86: fujitsu-laptop: do not log set_lcd_level() failures in bl_update_status() Michał Kępień <kernel@kempniu.pl> - 2017-04-05 09:00 +0200
  [PATCH v2 03/11] platform/x86: fujitsu-laptop: merge set_lcd_level_alt() into set_lcd_level() Michał Kępień <kernel@kempniu.pl> - 2017-04-05 09:00 +0200
    Re: [PATCH v2 03/11] platform/x86: fujitsu-laptop: merge  set_lcd_level_alt() into set_lcd_level() Jonathan Woithe <jwoithe@just42.net> - 2017-04-07 14:00 +0200
      Re: [PATCH v2 03/11] platform/x86: fujitsu-laptop: merge  set_lcd_level_alt() into set_lcd_level() Jonathan Woithe <jwoithe@just42.net> - 2017-04-07 14:10 +0200
  Re: [PATCH v2 00/11] fujitsu-laptop: backlight cleanup Darren Hart <dvhart@infradead.org> - 2017-04-05 17:40 +0200
    Re: [PATCH v2 00/11] fujitsu-laptop: backlight cleanup Michał Kępień <kernel@kempniu.pl> - 2017-04-05 22:00 +0200
      Re: [PATCH v2 00/11] fujitsu-laptop: backlight cleanup Jonathan Woithe <jwoithe@just42.net> - 2017-04-06 02:50 +0200
        Re: [PATCH v2 00/11] fujitsu-laptop: backlight cleanup Darren Hart <dvhart@infradead.org> - 2017-04-06 05:10 +0200
          Re: [PATCH v2 00/11] fujitsu-laptop: backlight cleanup Jonathan Woithe <jwoithe@just42.net> - 2017-04-07 14:20 +0200
            Re: [PATCH v2 00/11] fujitsu-laptop: backlight cleanup Darren Hart <dvhart@infradead.org> - 2017-04-07 20:00 +0200

csiph-web