Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1615510

Re: [PATCH] usb: misc: add missing continue and refactor code

Show all headers | View raw

Quoting Alan Stern <stern@rowland.harvard.edu>:

> On Mon, 3 Apr 2017, Greg Kroah-Hartman wrote:
>
>> On Mon, Apr 03, 2017 at 09:39:53AM -0500, Gustavo A. R. Silva wrote:
>> > -Code refactoring to make the flow easier to follow.
>> > -Add missing 'continue' for case USB_ENDPOINT_XFER_INT.
>>
>> Don't do multiple things in the same patch, please make these multiple
>> patches.  And do the "add missing continue" first, so it can be
>> backported to other kernels easier please.
>

OK, I will send a patchset shortly.

> Also, make sure your patch does not contain gratuitous whitespace
> changes.
>

Does it have any?
I ran it through checkpatch.pl before sending it and didn't see any.

Thanks
--
Gustavo A. R. Silva

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb: misc: add missing continue and refactor code "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-04-03 19:40 +0200
  Re: [PATCH] usb: misc: add missing continue and refactor code Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-04-03 20:00 +0200
    Re: [PATCH] usb: misc: add missing continue and refactor code Alan Stern <stern@rowland.harvard.edu> - 2017-04-03 20:40 +0200
      Re: [PATCH] usb: misc: add missing continue and refactor code "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-04-03 21:30 +0200
        [PATCH 1/2] usb: misc: add missing continue in switch "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-04-03 22:10 +0200

csiph-web