Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1615509
| From | David Howells <dhowells@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] KEYS: fix dereferencing NULL payload with nonzero length |
| Date | 2017-04-03 21:30 +0200 |
| Message-ID | <tsfPP-2Fz-7@gated-at.bofh.it> (permalink) |
| References | <tseqK-1BV-25@gated-at.bofh.it> <tryUx-8bT-3@gated-at.bofh.it> <tscoW-jE-31@gated-at.bofh.it> <tseqK-1BV-25@gated-at.bofh.it> |
| Organization | Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 |
Eric Biggers <ebiggers3@gmail.com> wrote:
> > > - if (_payload) {
> > > + if (plen) {
> >
> > "if (_payload && plen)" would be better.
> >
> > David
>
> No, that doesn't solve the problem. The problem is that userspace can pass
> in a NULL payload with nonzero length, causing the kernel to dereference a
> NULL pointer for some key types. For example:
Okay, in that case, I think there should be an else-statement that clears plen
if !_payload.
David
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] KEYS: fix dereferencing NULL payload with nonzero length Eric Biggers <ebiggers3@gmail.com> - 2017-04-01 23:40 +0200
Re: [PATCH] KEYS: fix dereferencing NULL payload with nonzero length David Howells <dhowells@redhat.com> - 2017-04-03 17:50 +0200
Re: [PATCH] KEYS: fix dereferencing NULL payload with nonzero length Eric Biggers <ebiggers3@gmail.com> - 2017-04-03 20:00 +0200
Re: [PATCH] KEYS: fix dereferencing NULL payload with nonzero length David Howells <dhowells@redhat.com> - 2017-04-03 21:30 +0200
Re: [PATCH] KEYS: fix dereferencing NULL payload with nonzero length Eric Biggers <ebiggers3@gmail.com> - 2017-04-03 23:40 +0200
csiph-web