Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1615341

Re: [PATCH v3 01/11] dt-bindings: add binding for the Allwinner DE2 CCU

Show all headers | View raw

On Thu, Mar 30, 2017 at 03:46:03AM +0800, Icenowy Zheng wrote:
> From: Icenowy Zheng <icenowy@aosc.xyz>
> 
> Allwinner "Display Engine 2.0" contains some clock controls in it.
> 
> In order to add them as clock drivers, we need a device tree binding.
> Add the binding here.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> ---
> Changes in v3:
> - Fill the address space length of DE2 CCU to 0x100000, just reach the start of mixer0.

Why? You waste virtual memory space making this bigger than it needs to 
be. Not an issue so much for 64-bit.

> 
>  .../devicetree/bindings/clock/sun8i-de2.txt        | 31 ++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/sun8i-de2.txt
> 
> diff --git a/Documentation/devicetree/bindings/clock/sun8i-de2.txt b/Documentation/devicetree/bindings/clock/sun8i-de2.txt
> new file mode 100644
> index 000000000000..34cf79c05f13
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/sun8i-de2.txt
> @@ -0,0 +1,31 @@
> +Allwinner Display Engine 2.0 Clock Control Binding
> +--------------------------------------------------
> +
> +Required properties :
> +- compatible: must contain one of the following compatibles:
> +		- "allwinner,sun8i-a83t-de2-clk"
> +		- "allwinner,sun50i-a64-de2-clk"
> +		- "allwinner,sun50i-h5-de2-clk"
> +
> +- reg: Must contain the registers base address and length
> +- clocks: phandle to the clocks feeding the display engine subsystem.
> +	  Three are needed:
> +  - "mod": the display engine module clock
> +  - "bus": the bus clock for the whole display engine subsystem
> +- clock-names: Must contain the clock names described just above
> +- resets: phandle to the reset control for the display engine subsystem.
> +- #clock-cells : must contain 1
> +- #reset-cells : must contain 1
> +
> +Example:
> +de2_clocks: clock@01000000 {

Drop the leading 0s. dtc in linux-next will now warn on this with W=1 
compile. Looks like sunxi has a lot of them. Please fix so we don't keep 
repeating this same copy-n-paste.

> +	compatible = "allwinner,sun50i-a64-de2-clk";
> +	reg = <0x01000000 0x100000>;
> +	clocks = <&ccu CLK_DE>,
> +		 <&ccu CLK_BUS_DE>;
> +	clock-names = "mod",
> +		      "bus";
> +	resets = <&ccu RST_BUS_DE>;
> +	#clock-cells = <1>;
> +	#reset-cells = <1>;
> +};
> -- 
> 2.12.0
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 00/11] Initial Allwinner Display Engine 2.0 Support Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 21:50 +0200
  [PATCH v3 07/11] drm/sun4i: Add compatible string for V3s display engine Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 22:00 +0200
  [PATCH v3 08/11] drm/sun4i: tcon: add support for V3s TCON Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 22:00 +0200
  [PATCH v3 01/11] dt-bindings: add binding for the Allwinner DE2 CCU Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 22:00 +0200
    Re: [PATCH v3 01/11] dt-bindings: add binding for the Allwinner DE2  CCU Rob Herring <robh@kernel.org> - 2017-04-03 17:40 +0200
  [PATCH v3 09/11] ARM: dts: sun8i: add DE2 nodes for V3s SoC Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 22:10 +0200
  [PATCH v3 10/11] ARM: dts: sun8i: add pinmux for LCD pins of V3s SoC Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 22:30 +0200
  [PATCH v3 11/11] [DO NOT MERGE] ARM: dts: sun8i: enable LCD panel of Lichee Pi Zero Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 22:40 +0200
  [PATCH v3 02/11] clk: sunxi-ng: add support for DE2 CCU Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 23:10 +0200
  [PATCH v3 03/11] dt-bindings: add bindings for DE2 on V3s SoC Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 23:30 +0200
    Re: [PATCH v3 03/11] dt-bindings: add bindings for DE2 on V3s SoC Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-03 10:10 +0200
  [PATCH v3 04/11] drm/sun4i: abstract the layer type Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 23:40 +0200
    Re: [PATCH v3 04/11] drm/sun4i: abstract the layer type Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-03 10:20 +0200
      Re: [PATCH v3 04/11] drm/sun4i: abstract the layer type Chen-Yu Tsai <wens@csie.org> - 2017-04-03 13:00 +0200
    Re: [PATCH v3 04/11] drm/sun4i: abstract the layer type Sean Paul <seanpaul@chromium.org> - 2017-04-04 21:30 +0200
      Re: [linux-sunxi] Re: [PATCH v3 04/11] drm/sun4i: abstract the layer type Chen-Yu Tsai <wens@csie.org> - 2017-04-05 04:30 +0200
        Re: [linux-sunxi] Re: [PATCH v3 04/11] drm/sun4i: abstract the layer  type icenowy@aosc.io - 2017-04-05 19:20 +0200
  [PATCH v3 06/11] drm/sun4i: add support for Allwinner DE2 mixers Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 23:50 +0200
    Re: [linux-sunxi] [PATCH v3 06/11] drm/sun4i: add support for Allwinner DE2 mixers Jernej Škrabec <jernej.skrabec@siol.net> - 2017-03-30 00:40 +0200
  [PATCH v3 05/11] drm/sun4i: abstract a mixer type Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 23:50 +0200
    Re: [PATCH v3 05/11] drm/sun4i: abstract a mixer type Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-03 10:30 +0200

csiph-web