Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1614960

Re: [PATCH v3 03/11] dt-bindings: add bindings for DE2 on V3s SoC

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Mar 30, 2017 at 03:46:05AM +0800, Icenowy Zheng wrote:
> From: Icenowy Zheng <icenowy@aosc.xyz>
> 
> Allwinner V3s SoC have a display engine which have a different pipeline
> with older SoCs.
> 
> Add document for it (new compatibles and the new "mixer" part).
> 
> The paragraph of TCON is also refactored, for furtherly add TCONs in
> A83T/H3/A64/H5 that have only a channel 1 (used for HDMI or TV Encoder).
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> ---
> Changes in v3:
> - Remove the description of having a BE directly as allwinner,pipeline.
> 
>  .../bindings/display/sunxi/sun4i-drm.txt           | 37 +++++++++++++++++++---
>  1 file changed, 33 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
> index b82c00449468..38de5e96f359 100644
> --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
> +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
> @@ -31,11 +31,11 @@ Required properties:
>     * allwinner,sun6i-a31-tcon
>     * allwinner,sun6i-a31s-tcon
>     * allwinner,sun8i-a33-tcon
> +   * allwinner,sun8i-v3s-tcon
>   - reg: base address and size of memory-mapped region
>   - interrupts: interrupt associated to this IP
> - - clocks: phandles to the clocks feeding the TCON. Three are needed:
> + - clocks: phandles to the clocks feeding the TCON
>     - 'ahb': the interface clocks
> -   - 'tcon-ch0': The clock driving the TCON channel 0
>   - resets: phandles to the reset controllers driving the encoder
>     - "lcd": the reset line for the TCON channel 0
>  
> @@ -52,7 +52,12 @@ Required properties:
>    second the block connected to the TCON channel 1 (usually the TV
>    encoder)
>  
> -On SoCs other than the A33, there is one more clock required:
> +On TCONs that have a channel 0 (currently all TCONs supported), there
> +is one more clock required:
> +   - 'tcon-ch0': The clock driving the TCON channel 0
> +

Why did you change that if they all have a channel 0?

> +On TCONs that have a channel 1 (currently all TCONs except the ones in
> +A33 and V3s), there is one more clock required:
>     - 'tcon-ch1': The clock driving the TCON channel 1

And that can be added too just by saying "On SoCs other than the A33
and V3".

Looks good otherwise, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 00/11] Initial Allwinner Display Engine 2.0 Support Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 21:50 +0200
  [PATCH v3 07/11] drm/sun4i: Add compatible string for V3s display engine Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 22:00 +0200
  [PATCH v3 08/11] drm/sun4i: tcon: add support for V3s TCON Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 22:00 +0200
  [PATCH v3 01/11] dt-bindings: add binding for the Allwinner DE2 CCU Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 22:00 +0200
    Re: [PATCH v3 01/11] dt-bindings: add binding for the Allwinner DE2  CCU Rob Herring <robh@kernel.org> - 2017-04-03 17:40 +0200
  [PATCH v3 09/11] ARM: dts: sun8i: add DE2 nodes for V3s SoC Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 22:10 +0200
  [PATCH v3 10/11] ARM: dts: sun8i: add pinmux for LCD pins of V3s SoC Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 22:30 +0200
  [PATCH v3 11/11] [DO NOT MERGE] ARM: dts: sun8i: enable LCD panel of Lichee Pi Zero Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 22:40 +0200
  [PATCH v3 02/11] clk: sunxi-ng: add support for DE2 CCU Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 23:10 +0200
  [PATCH v3 03/11] dt-bindings: add bindings for DE2 on V3s SoC Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 23:30 +0200
    Re: [PATCH v3 03/11] dt-bindings: add bindings for DE2 on V3s SoC Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-03 10:10 +0200
  [PATCH v3 04/11] drm/sun4i: abstract the layer type Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 23:40 +0200
    Re: [PATCH v3 04/11] drm/sun4i: abstract the layer type Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-03 10:20 +0200
      Re: [PATCH v3 04/11] drm/sun4i: abstract the layer type Chen-Yu Tsai <wens@csie.org> - 2017-04-03 13:00 +0200
    Re: [PATCH v3 04/11] drm/sun4i: abstract the layer type Sean Paul <seanpaul@chromium.org> - 2017-04-04 21:30 +0200
      Re: [linux-sunxi] Re: [PATCH v3 04/11] drm/sun4i: abstract the layer type Chen-Yu Tsai <wens@csie.org> - 2017-04-05 04:30 +0200
        Re: [linux-sunxi] Re: [PATCH v3 04/11] drm/sun4i: abstract the layer  type icenowy@aosc.io - 2017-04-05 19:20 +0200
  [PATCH v3 06/11] drm/sun4i: add support for Allwinner DE2 mixers Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 23:50 +0200
    Re: [linux-sunxi] [PATCH v3 06/11] drm/sun4i: add support for Allwinner DE2 mixers Jernej Škrabec <jernej.skrabec@siol.net> - 2017-03-30 00:40 +0200
  [PATCH v3 05/11] drm/sun4i: abstract a mixer type Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 23:50 +0200
    Re: [PATCH v3 05/11] drm/sun4i: abstract a mixer type Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-03 10:30 +0200

csiph-web