Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1615215
| From | Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/3] pwm: pwm-samsung: remove redundant checks from pwm_samsung_config() |
| Date | 2017-04-03 15:50 +0200 |
| Message-ID | <tsawO-7yd-29@gated-at.bofh.it> (permalink) |
| References | <tsawO-7yd-7@gated-at.bofh.it> <tsawP-7yd-31@gated-at.bofh.it> <tsawO-7yd-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
If the requested period_ns and duty_ns values are identical to the last programmed ones pwm_samsung_config() returns early and skips the hardware configuration. The same checks are now done by the PWM core so the driver specific ones can be removed. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> --- drivers/pwm/pwm-samsung.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c index f113cda..9ea7638 100644 --- a/drivers/pwm/pwm-samsung.c +++ b/drivers/pwm/pwm-samsung.c @@ -312,9 +312,6 @@ static int pwm_samsung_config(struct pwm_chip *chip, struct pwm_device *pwm, if (period_ns > NSEC_PER_SEC) return -ERANGE; - if (period_ns == chan->period_ns && duty_ns == chan->duty_ns) - return 0; - tcnt = readl(our_chip->base + REG_TCNTB(pwm->hwpwm)); oldtcmp = readl(our_chip->base + REG_TCMPB(pwm->hwpwm)); -- 1.9.1
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/3] pwm: pwm-samsung: fix suspend/resume support Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-04-03 15:50 +0200 [PATCH 1/3] pwm: pwm-samsung: remove redundant checks from pwm_samsung_config() Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-04-03 15:50 +0200 [PATCH 2/3] pwm: pwm-samsung: fix suspend/resume support Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-04-03 15:50 +0200
csiph-web