Re: [PATCH 2/3] arm64: allwinner: a64: add USB0 OHCI/EHCI related devicetree parts

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] arm64: allwinner: a64: add USB0 OHCI/EHCI related devicetree parts
Date	2017-04-05 10:20 +0200
Message-ID	<tsOky-8y-27@gated-at.bofh.it> (permalink)
References	(1 earlier) <tsBGF-dZ-5@gated-at.bofh.it> <tsNou-7Zm-15@gated-at.bofh.it> <tsNya-82s-5@gated-at.bofh.it> <tsNya-82s-3@gated-at.bofh.it> <tsNHQ-85H-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Apr 05, 2017 at 03:33:09PM +0800, Icenowy Zheng wrote:
> > > P.S. to be compatible with older DTs, I think I should adjust
> > > the phy driver, make it enable dual-route function only when
> > > pmu0 is present.
> > 
> > That, or if we're quick enough, we can still add it to 4.11. There's a
> > bit of time left.
> 
> Thus the device tree binding patch and the DT part of this patchset
> should be all pushed to 4.11 .
> 
> The device tree binding patch is commit ee73fd7dfc86 ("dt: bindings:
> add pmu0 regs for USB PHYs on Allwinner H3/V3s/A64").

It should have always been there. If there is a register for the PHY
somewhere, it must be in the DT node. Period. There's not relation to
whether the driver actually uses it or not.

Please send a patch to add that range for 4.11.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Thread

[PATCH 1/3] phy: sun4i-usb: enable PHY0 dual route switching for A64 USB PHY Icenowy Zheng <icenowy@aosc.io> - 2017-04-04 20:50 +0200
  [PATCH 3/3] arm64: allwinner: a64: enable EHCI0/OHCI0 controller for Pine64 Icenowy Zheng <icenowy@aosc.io> - 2017-04-04 20:50 +0200
  [PATCH 2/3] arm64: allwinner: a64: add USB0 OHCI/EHCI related devicetree parts Icenowy Zheng <icenowy@aosc.io> - 2017-04-04 20:50 +0200
    Re: [PATCH 2/3] arm64: allwinner: a64: add USB0 OHCI/EHCI related  devicetree parts Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-05 09:20 +0200
      Re: [PATCH 2/3] arm64: allwinner: a64: add USB0 OHCI/EHCI related  devicetree parts Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-05 09:30 +0200
        Re: [PATCH 2/3] arm64: allwinner: a64: add USB0 OHCI/EHCI related  devicetree parts Icenowy Zheng <icenowy@aosc.io> - 2017-04-05 09:40 +0200
          Re: [PATCH 2/3] arm64: allwinner: a64: add USB0 OHCI/EHCI related  devicetree parts Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-05 10:20 +0200
  Re: [PATCH 1/3] phy: sun4i-usb: enable PHY0 dual route switching for  A64 USB PHY Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-05 09:10 +0200
    Re: [PATCH 1/3] phy: sun4i-usb: enable PHY0 dual route switching for  A64 USB PHY Kishon Vijay Abraham I <kishon@ti.com> - 2017-04-05 12:10 +0200

csiph-web