Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1614899

Re: [PATCH 3/5] zram: use zram_slot_lock instead of raw bit_spin_lock op

Show all headers | View raw

Hello Minchan,

On (04/03/17 14:17), Minchan Kim wrote:
> With this clean-up phase, I want to use zram's wrapper function
> to lock table access which is more consistent with other zram's
> functions.

which reminds me of...

there was a discussion a long time ago, -rt people absolutely
hate bit spin_locks and they suggested us to replace it with
normal spin_locks (and I promised to take a look at it, but
got interrupted and never really returned back to it).

for !lockdep builds the impact is somewhat small; for lockdep
builds we increase the memory usage, but

a) lockdep builds are debug builds by definition, no one runs lockdep
   enabled kernels in production

b) we have lockdep in zram now, which is nice

c) spin_locks probably have better fairness guarantees


what do you think? can we, in this patch set, also replce bit
spin_locks with a normal spin_lock?

	-ss

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/5] zram: use zram_slot_lock instead of raw bit_spin_lock op Minchan Kim <minchan@kernel.org> - 2017-04-03 07:20 +0200
  Re: [PATCH 3/5] zram: use zram_slot_lock instead of raw  bit_spin_lock op Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-04-03 08:10 +0200
    Re: [PATCH 3/5] zram: use zram_slot_lock instead of raw  bit_spin_lock op Minchan Kim <minchan@kernel.org> - 2017-04-03 08:40 +0200
      Re: [PATCH 3/5] zram: use zram_slot_lock instead of raw  bit_spin_lock op Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-04-03 10:10 +0200
  Re: [PATCH 3/5] zram: use zram_slot_lock instead of raw  bit_spin_lock op Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-04-04 04:20 +0200
    Re: [PATCH 3/5] zram: use zram_slot_lock instead of raw  bit_spin_lock op Minchan Kim <minchan@kernel.org> - 2017-04-04 07:00 +0200

csiph-web