Re: [PATCH] staging: rtl8712: fixed multiple line derefence issue

From	Prasant Jalan <prasant.jalan@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: rtl8712: fixed multiple line derefence issue
Date	2017-04-03 08:10 +0200
Message-ID	<ts3lD-35U-13@gated-at.bofh.it> (permalink)
References	<tqqFH-2pt-1@gated-at.bofh.it> <ts1Dc-1UL-5@gated-at.bofh.it> <ts2fT-2bK-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Apr 3, 2017 at 10:27 AM, Joe Perches <joe@perches.com> wrote:
> On Mon, 2017-04-03 at 09:43 +0530, Prasant Jalan wrote:
>> On Thu, Mar 30, 2017 at 12:03 AM, Prasant Jalan <prasant.jalan@gmail.com> wrote:
>> > Checkpatch emits WARNING: Avoid multiple line dereference.
>> >
>> > Trivial indentation improvement helps fix the checkpatch warning.
> []
>> > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c
> []
>> > @@ -416,15 +417,14 @@ static sint xmitframe_addmic(struct _adapter *padapter,
>> >                                                            &pframe[10], 6);
>> >                         }
>> >                         if (pqospriv->qos_option == 1)
>> > -                                       priority[0] = (u8)pxmitframe->
>> > -                                                     attrib.priority;
>> > +                               priority[0] = (u8)pxmitframe->attrib.priority;
>> >                         r8712_secmicappend(&micdata, &priority[0], 4);
>> >                         payload = pframe;
>> >                         for (curfragnum = 0; curfragnum < pattrib->nr_frags;
>> >                              curfragnum++) {
>> >                                 payload = (u8 *)RND4((addr_t)(payload));
>> > -                               payload = payload + pattrib->
>> > -                                         hdrlen + pattrib->iv_len;
>> > +                               payload = payload + pattrib->hdrlen +
>> > +                                         pattrib->iv_len;
>
> += would be shorter

Hi Joe,

Looks like back to school for me for overlooking such a trivial thing.

Thanks for the pointer, I will update the patch and resend.


Regards, Prasant

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: rtl8712: fixed multiple line derefence issue Prasant Jalan <prasant.jalan@gmail.com> - 2017-03-29 20:40 +0200
  Re: [PATCH] staging: rtl8712: fixed multiple line derefence issue Prasant Jalan <prasant.jalan@gmail.com> - 2017-04-03 06:20 +0200
    Re: [PATCH] staging: rtl8712: fixed multiple line derefence issue Joe Perches <joe@perches.com> - 2017-04-03 07:00 +0200
      Re: [PATCH] staging: rtl8712: fixed multiple line derefence issue Prasant Jalan <prasant.jalan@gmail.com> - 2017-04-03 08:10 +0200

csiph-web