[PATCH] net: hns: fix boolreturn.cocci warnings

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	kbuild test robot <lkp@intel.com>
Newsgroups	linux.kernel
Subject	[PATCH] net: hns: fix boolreturn.cocci warnings
Date	Sat, 01 Apr 2017 02:00:01 +0200
Message-ID	<treCt-2V3-7@gated-at.bofh.it> (permalink)
References	<treCt-2V3-5@gated-at.bofh.it> <tqKl5-8nZ-55@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491004297; x=1522540297; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=SpVJeu3VU7YQLtuMMi2XvApibQP9BdgP09K5xYtzHv0=; b=JlHch7nsa3R2RkPWw3OpP5vKsbslLEru3aaas14i3Tz2C1mWpeot1m/f eJOxyISgJlaEPm3AICRpAcRFAKKtlQ==;
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.36,254,1486454400"; d="scan'208";a="83315514"
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
X-Sa-Exim-Connect-IP	<locally generated>
X-Sa-Exim-Mail-From	fengguang.wu@intel.com
X-Sa-Exim-Scanned	No (on bee); SAEximRunCond expanded to false
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	24
Organization	linux.* mail to news gateway
X-Original-Cc	kbuild-all@01.org, davem@davemloft.net, salil.mehta@huawei.com, yisen.zhuang@huawei.com, mehta.salil.lnk@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, lipeng <lipeng321@huawei.com>
X-Original-Date	Sat, 1 Apr 2017 07:50:55 +0800
X-Original-Message-ID	<20170331235055.GA28462@lkp-wsm-ep1>
X-Original-References	<201704010733.8LNMN4m7%fengguang.wu@intel.com> <20170330153106.14344-9-salil.mehta@huawei.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1614334

Show key headers only | View raw

drivers/net/ethernet/hisilicon/hns/hns_enet.c:1548:8-9: WARNING: return of 0/1 in function 'hns_enable_serdes_lb' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

CC: lipeng <lipeng321@huawei.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 hns_enet.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
@@ -1545,7 +1545,7 @@ static bool hns_enable_serdes_lb(struct
 	/* wait h/w ready */
 	mdelay(300);
 
-	return 0;
+	return false;
 }
 
 static void hns_disable_serdes_lb(struct net_device *ndev)

Thread

[PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code Improvements Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 17/19] net: hns: Adjust the SBM module buffer threshold Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 16/19] net: hns: Simplify the exception sequence in hns_ppe_init() Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 12/19] net: hns: Remove redundant mac_get_id() Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 05/19] net: hns: Remove redundant memset during buffer release Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 13/19] net: hns: Remove redundant mac table operations Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 02/19] net: hns: Modify GMAC init TX threshold value Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 04/19] net: hns: Change the TX queue selection algorithm Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 19/19] net: hns: Some checkpatch.pl script & warning fixes Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 15/19] net: hns: Optimise the code in hns_mdio_wait_ready() Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 07/19] net: hns: Optimize hns_nic_common_poll for better performance Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 06/19] net: hns: bug fix of ethtool show the speed Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 08/19] net: hns: Fix to adjust buf_size of ring according to mtu Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
    Re: [PATCH net 08/19] net: hns: Fix to adjust buf_size of ring  according to mtu kbuild test robot <lkp@intel.com> - 2017-04-01 02:00 +0200
    [PATCH] net: hns: fix boolreturn.cocci warnings kbuild test robot <lkp@intel.com> - 2017-04-01 02:00 +0200
      Re: [PATCH] net: hns: fix boolreturn.cocci warnings David Miller <davem@davemloft.net> - 2017-04-03 04:50 +0200
        Re: [kbuild-all] [PATCH] net: hns: fix boolreturn.cocci warnings Fengguang Wu <lkp@intel.com> - 2017-04-03 05:00 +0200
  [PATCH net 09/19] net: hns: Replace netif_tx_lock to ring spin lock Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 10/19] net: hns: Correct HNS RSS key set function Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 03/19] net: hns: Optimize the code for GMAC pad and crc Config Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 14/19] net: hns: Clean redundant code from hns_mdio.c file Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 01/19] net: hns: Fix the implementation of irq affinity function Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:50 +0200
  Re: [PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code  Improvements David Miller <davem@davemloft.net> - 2017-03-30 19:10 +0200
    RE: [PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code  Improvements Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 19:30 +0200
      Re: [PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code  Improvements David Miller <davem@davemloft.net> - 2017-03-30 19:30 +0200
        RE: [PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code  Improvements Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 19:30 +0200
  Re: [PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code  Improvements David Miller <davem@davemloft.net> - 2017-03-31 05:10 +0200
    RE: [PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code  Improvements Salil Mehta <salil.mehta@huawei.com> - 2017-03-31 12:00 +0200

csiph-web