Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1614867

Re: [kbuild-all] [PATCH] net: hns: fix boolreturn.cocci warnings

Show all headers | View raw

Hi David,

On Sun, Apr 02, 2017 at 07:44:02PM -0700, David Miller wrote:
>From: kbuild test robot <lkp@intel.com>
>Date: Sat, 1 Apr 2017 07:50:55 +0800
>
>> drivers/net/ethernet/hisilicon/hns/hns_enet.c:1548:8-9: WARNING: return of 0/1 in function 'hns_enable_serdes_lb' with return type bool
>>
>>  Return statements in functions returning bool should use
>>  true/false instead of 1/0.
>> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>>
>> CC: lipeng <lipeng321@huawei.com>
>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>
>This doesn't apply to any of my trees.

It's a reply to Salil's patch

        [PATCH net 08/19] net: hns: Fix to adjust buf_size of ring according to mtu

and so is based on that patch.

What can the robot improve to avoid you confusing it as a general
patch for the net master trees? One possible way is to change title to

        [PATCH for Salil] net: hns: fix boolreturn.cocci warnings
        ^^^^^^^^^^^^^^^^^

Regards,
Fengguang

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code Improvements Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 17/19] net: hns: Adjust the SBM module buffer threshold Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 16/19] net: hns: Simplify the exception sequence in hns_ppe_init() Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 12/19] net: hns: Remove redundant mac_get_id() Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 05/19] net: hns: Remove redundant memset during buffer release Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 13/19] net: hns: Remove redundant mac table operations Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 02/19] net: hns: Modify GMAC init TX threshold value Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 04/19] net: hns: Change the TX queue selection algorithm Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 19/19] net: hns: Some checkpatch.pl script & warning fixes Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 15/19] net: hns: Optimise the code in hns_mdio_wait_ready() Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 07/19] net: hns: Optimize hns_nic_common_poll for better performance Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 06/19] net: hns: bug fix of ethtool show the speed Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 08/19] net: hns: Fix to adjust buf_size of ring according to mtu Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
    Re: [PATCH net 08/19] net: hns: Fix to adjust buf_size of ring  according to mtu kbuild test robot <lkp@intel.com> - 2017-04-01 02:00 +0200
    [PATCH] net: hns: fix boolreturn.cocci warnings kbuild test robot <lkp@intel.com> - 2017-04-01 02:00 +0200
      Re: [PATCH] net: hns: fix boolreturn.cocci warnings David Miller <davem@davemloft.net> - 2017-04-03 04:50 +0200
        Re: [kbuild-all] [PATCH] net: hns: fix boolreturn.cocci warnings Fengguang Wu <lkp@intel.com> - 2017-04-03 05:00 +0200
  [PATCH net 09/19] net: hns: Replace netif_tx_lock to ring spin lock Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 10/19] net: hns: Correct HNS RSS key set function Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 03/19] net: hns: Optimize the code for GMAC pad and crc Config Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 14/19] net: hns: Clean redundant code from hns_mdio.c file Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:40 +0200
  [PATCH net 01/19] net: hns: Fix the implementation of irq affinity function Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 17:50 +0200
  Re: [PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code  Improvements David Miller <davem@davemloft.net> - 2017-03-30 19:10 +0200
    RE: [PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code  Improvements Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 19:30 +0200
      Re: [PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code  Improvements David Miller <davem@davemloft.net> - 2017-03-30 19:30 +0200
        RE: [PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code  Improvements Salil Mehta <salil.mehta@huawei.com> - 2017-03-30 19:30 +0200
  Re: [PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code  Improvements David Miller <davem@davemloft.net> - 2017-03-31 05:10 +0200
    RE: [PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code  Improvements Salil Mehta <salil.mehta@huawei.com> - 2017-03-31 12:00 +0200

csiph-web