Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1614763

Re: [PATCH v3 0/5] Add support for the R_CCU on Allwinner H3/A64 SoCs

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Wed, Mar 29, 2017 at 06:42:41PM +0800, Icenowy Zheng wrote:
> Allwinner SoCs after sun6i-a31 nearly all have a R_CCU in PRCM part.
> (V3s and R40 do not have it, as they have even no PRCM)
> 
> This patch adds support for the ones on H3/A64.
> 
> Some clock/reset values are reserved for easier extending the support to
> A31/A23, but for this I think some changes to the PRCM MFD should be made,
> see [1] (Although this is only a sketch).
> 
> The r_pio device node is also added for A64, as the driver is already
> merged, and its depends (r_ccu) is now met.
> 
> [1] https://github.com/wens/linux/commits/sunxi-ng-prcm

It looks good now, thanks.

Beside from the minor fix you've mentionned, please don't use the
defined IDs (yet) in your DT patches (3 to 5).

It will be a PITA to get merged otherwise. We'll fix it later.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/5] Add support for the R_CCU on Allwinner H3/A64 SoCs Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 12:50 +0200
  [PATCH v3 2/5] clk: sunxi-ng: add support for PRCM CCUs Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 12:50 +0200
    Re: [PATCH v3 2/5] clk: sunxi-ng: add support for PRCM CCUs Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 17:40 +0200
  [PATCH v3 1/5] dt-bindings: update device tree binding for Allwinner PRCM CCUs Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 12:50 +0200
    Re: [PATCH v3 1/5] dt-bindings: update device tree binding for  Allwinner PRCM CCUs Rob Herring <robh@kernel.org> - 2017-04-03 17:00 +0200
  [PATCH v3 3/5] arm64: allwinner: a64: add r_ccu node Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 13:10 +0200
  [PATCH v3 4/5] ARM: sunxi: h3/h5: switch apb0-related clocks to r_ccu Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 13:30 +0200
  [PATCH v3 5/5] arm64: allwinner: a64: add R_PIO pinctrl node Icenowy Zheng <icenowy@aosc.io> - 2017-03-29 13:50 +0200
  Re: [PATCH v3 0/5] Add support for the R_CCU on Allwinner H3/A64 SoCs Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-02 18:10 +0200
    Re: [PATCH v3 0/5] Add support for the R_CCU on Allwinner H3/A64  SoCs Icenowy Zheng <icenowy@aosc.io> - 2017-04-02 18:40 +0200
      Re: [PATCH v3 0/5] Add support for the R_CCU on Allwinner H3/A64 SoCs Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-03 09:40 +0200

csiph-web