Re: [PATCH net-next v2] net: mvneta: set rx mode during resume if interface is running

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next v2] net: mvneta: set rx mode during resume if interface is running
Date	2017-03-29 23:20 +0200
Message-ID	<tqtaA-4hp-55@gated-at.bofh.it> (permalink)
References	<tqhCp-4pL-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Jisheng Zhang <jszhang@marvell.com>
Date: Wed, 29 Mar 2017 16:47:19 +0800

> I found a bug by:
> 
> 0. boot and start dhcp client
> 1. echo mem > /sys/power/state
> 2. resume back immediately
> 3. don't touch dhcp client to renew the lease
> 4. ping the gateway. No acks
> 
> Usually, after step2, the DHCP lease isn't expired, so in theory we
> should resume all back. But in fact, it doesn't. It turns out
> the rx mode isn't resumed correctly. This patch fixes it by adding
> mvneta_set_rx_mode(dev) in the resume hook if interface is running.
> 
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> Since v1:
>  - rebased to the latest net-next tree and explictly mention it

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next v2] net: mvneta: set rx mode during resume if interface is running Jisheng Zhang <jszhang@marvell.com> - 2017-03-29 11:00 +0200
  Re: [PATCH net-next v2] net: mvneta: set rx mode during resume if  interface is running Andrew Lunn <andrew@lunn.ch> - 2017-03-29 15:00 +0200
  Re: [PATCH net-next v2] net: mvneta: set rx mode during resume if  interface is running David Miller <davem@davemloft.net> - 2017-03-29 23:20 +0200

csiph-web