Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1611908

Re: [PATCH net-next v2] net: mvneta: set rx mode during resume if interface is running

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: [PATCH net-next v2] net: mvneta: set rx mode during resume if interface is running
Date 2017-03-29 15:00 +0200
Message-ID <tqlmG-6Yd-33@gated-at.bofh.it> (permalink)
References <tqhCp-4pL-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Mar 29, 2017 at 04:47:19PM +0800, Jisheng Zhang wrote:
> I found a bug by:
> 
> 0. boot and start dhcp client
> 1. echo mem > /sys/power/state
> 2. resume back immediately
> 3. don't touch dhcp client to renew the lease
> 4. ping the gateway. No acks
> 
> Usually, after step2, the DHCP lease isn't expired, so in theory we
> should resume all back. But in fact, it doesn't. It turns out
> the rx mode isn't resumed correctly. This patch fixes it by adding
> mvneta_set_rx_mode(dev) in the resume hook if interface is running.
> 
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH net-next v2] net: mvneta: set rx mode during resume if interface is running Jisheng Zhang <jszhang@marvell.com> - 2017-03-29 11:00 +0200
  Re: [PATCH net-next v2] net: mvneta: set rx mode during resume if  interface is running Andrew Lunn <andrew@lunn.ch> - 2017-03-29 15:00 +0200
  Re: [PATCH net-next v2] net: mvneta: set rx mode during resume if  interface is running David Miller <davem@davemloft.net> - 2017-03-29 23:20 +0200

csiph-web