Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1612125

[PATCH 0/7] NFC: fix device allocation and nfcmrvl crashes

Show all headers | View raw

This started out with the observation that the nfcmrvl_uart driver
unconditionally dereferenced the tty class device despite the fact that
not every tty has an associated struct device (Unix98 ptys). Some
further changes were needed in the common nfcmrvl code to fully address
this, some of which also incidentally fixed a few related bugs (e.g.
resource leaks in error paths).

While fixing this I stumbled over a regression in NFC core that lead to
broken registration error paths and misnamed workqueues.

Note that this has only been tested by configuring the n_hci line
discipline for different ttys without any actual NFC hardware connected.

Johan


Johan Hovold (7):
  NFC: fix broken device allocation
  NFC: nfcmrvl_uart: add missing tty-device sanity check
  NFC: nfcmrvl: do not use device-managed resources
  NFC: nfcmrvl: use nfc-device for firmware download
  NFC: nfcmrvl: fix firmware-management initialisation
  NFC: nfcmrvl_uart: fix device-node leak during probe
  NFC: nfcmrvl_usb: use interface as phy device

 drivers/nfc/nfcmrvl/fw_dnld.c |  7 +++++--
 drivers/nfc/nfcmrvl/main.c    | 25 +++++++++++++------------
 drivers/nfc/nfcmrvl/uart.c    | 11 +++++++----
 drivers/nfc/nfcmrvl/usb.c     |  4 +---
 net/nfc/core.c                | 31 ++++++++++++++++++-------------
 net/nfc/nci/core.c            |  3 +--
 6 files changed, 45 insertions(+), 36 deletions(-)

-- 
2.12.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] NFC: fix device allocation and nfcmrvl crashes Johan Hovold <johan@kernel.org> - 2017-03-29 18:30 +0200
  [PATCH 3/7] NFC: nfcmrvl: do not use device-managed resources Johan Hovold <johan@kernel.org> - 2017-03-29 18:30 +0200
    Re: [PATCH 3/7] NFC: nfcmrvl: do not use device-managed resources Johan Hovold <johan@kernel.org> - 2017-03-29 22:50 +0200
  [PATCH 4/7] NFC: nfcmrvl: use nfc-device for firmware download Johan Hovold <johan@kernel.org> - 2017-03-29 18:30 +0200
  [PATCH 5/7] NFC: nfcmrvl: fix firmware-management initialisation Johan Hovold <johan@kernel.org> - 2017-03-29 18:30 +0200
  [PATCH 7/7] NFC: nfcmrvl_usb: use interface as phy device Johan Hovold <johan@kernel.org> - 2017-03-29 18:30 +0200
  [PATCH 2/7] NFC: nfcmrvl_uart: add missing tty-device sanity check Johan Hovold <johan@kernel.org> - 2017-03-29 18:30 +0200
  [PATCH 1/7] NFC: fix broken device allocation Johan Hovold <johan@kernel.org> - 2017-03-29 18:30 +0200
  [PATCH 6/7] NFC: nfcmrvl_uart: fix device-node leak during probe Johan Hovold <johan@kernel.org> - 2017-03-29 18:30 +0200

csiph-web