Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1612131
| From | Johan Hovold <johan@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 7/7] NFC: nfcmrvl_usb: use interface as phy device |
| Date | 2017-03-29 18:30 +0200 |
| Message-ID | <tqoDU-ZD-15@gated-at.bofh.it> (permalink) |
| References | <tqoDU-ZD-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Use the USB-interface rather than parent USB-device device, which is what this driver binds to, when registering the nci device. Note that using the right device is important when dealing with device- managed resources as the interface can be unbound independently of the parent device. Also note that private device pointer had already been set by nfcmrvl_nci_register_dev() so the redundant assignment can therefore be removed. Signed-off-by: Johan Hovold <johan@kernel.org> --- drivers/nfc/nfcmrvl/usb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/nfc/nfcmrvl/usb.c b/drivers/nfc/nfcmrvl/usb.c index 585a0f20835b..728b3321842d 100644 --- a/drivers/nfc/nfcmrvl/usb.c +++ b/drivers/nfc/nfcmrvl/usb.c @@ -341,15 +341,13 @@ static int nfcmrvl_probe(struct usb_interface *intf, init_usb_anchor(&drv_data->deferred); priv = nfcmrvl_nci_register_dev(NFCMRVL_PHY_USB, drv_data, &usb_ops, - &drv_data->udev->dev, &config); + &intf->dev, &config); if (IS_ERR(priv)) return PTR_ERR(priv); drv_data->priv = priv; drv_data->priv->support_fw_dnld = false; - priv->dev = &drv_data->udev->dev; - usb_set_intfdata(intf, drv_data); return 0; -- 2.12.2
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/7] NFC: fix device allocation and nfcmrvl crashes Johan Hovold <johan@kernel.org> - 2017-03-29 18:30 +0200
[PATCH 3/7] NFC: nfcmrvl: do not use device-managed resources Johan Hovold <johan@kernel.org> - 2017-03-29 18:30 +0200
Re: [PATCH 3/7] NFC: nfcmrvl: do not use device-managed resources Johan Hovold <johan@kernel.org> - 2017-03-29 22:50 +0200
[PATCH 4/7] NFC: nfcmrvl: use nfc-device for firmware download Johan Hovold <johan@kernel.org> - 2017-03-29 18:30 +0200
[PATCH 5/7] NFC: nfcmrvl: fix firmware-management initialisation Johan Hovold <johan@kernel.org> - 2017-03-29 18:30 +0200
[PATCH 7/7] NFC: nfcmrvl_usb: use interface as phy device Johan Hovold <johan@kernel.org> - 2017-03-29 18:30 +0200
[PATCH 2/7] NFC: nfcmrvl_uart: add missing tty-device sanity check Johan Hovold <johan@kernel.org> - 2017-03-29 18:30 +0200
[PATCH 1/7] NFC: fix broken device allocation Johan Hovold <johan@kernel.org> - 2017-03-29 18:30 +0200
[PATCH 6/7] NFC: nfcmrvl_uart: fix device-node leak during probe Johan Hovold <johan@kernel.org> - 2017-03-29 18:30 +0200
csiph-web