Re: [PATCH] ext4: Add statx support

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ext4: Add statx support
Date	2017-03-31 10:10 +0200
Message-ID	<tqZN9-204-45@gated-at.bofh.it> (permalink)
References	<tlSVX-1l6-5@gated-at.bofh.it> <tlBV7-62w-3@gated-at.bofh.it> <tlSVX-1l6-5@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

Eric Biggers <ebiggers3@gmail.com> wrote:

> Ultimately this needs to be addressed in ext4 more fully, but how about for
> ->getattr() just skipping the call to ext4_get_inode_flags() and instead
> populating the generic attributes like STATX_ATTR_APPEND and
> STATX_ATTR_IMMUTABLE from the generic inode flags, rather than from the
> ext4-specific flags?  Actually, it could even be done in generic_fillattr(), so
> that all filesystems benefit.

For the moment, taking Andreas's comments into account, I'll just drop the
call to ext4_get_inode_flags() and just assume ei->i_flags is correct.

I'm not sure whether to push the APPEND and IMMUTABLE attribute transfers to
the generic code - it makes sense for all filesystems that support such flags
and not for those that don't:-/  And, true, the same could be said of the
AUTOMMOUNT attribute.

David

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] ext4: Add statx support David Howells <dhowells@redhat.com> - 2017-03-31 10:10 +0200

csiph-web