Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1613724

Re: [PATCH 1/1] irq: add IRQF_TRIGGER_MASK on PPI by default

Show all headers | View raw

On Thu, 30 Mar 2017, Aniruddha Banerjee wrote:

> add IRQF_TRIGGER_MASK on PPI by default so that the PPIs are
> not configured as edge-triggered, which may be wrong for certain GIC
> implementations such as the GIC-400

The above is just useless blurb.

I can't figure out at all WHY a generic interface has anything to do with
edge trigger configuration.

I assume this is (Nvidia) GIC specific nonsense, so why are you inflicting
this on every caller of this interface unconditionally w/o explaining what
the impact of this change might be and why it does not cause havoc for any
existing caller?

This is function is implemented in kernel/irq/ not in foo/gic/ so you
better come up with some coherent explanation.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] irq: add IRQF_TRIGGER_MASK on PPI by default Aniruddha Banerjee <aniruddhab@nvidia.com> - 2017-03-30 21:50 +0200
  Re: [PATCH 1/1] irq: add IRQF_TRIGGER_MASK on PPI by default Thomas Gleixner <tglx@linutronix.de> - 2017-03-31 10:10 +0200
    Re: [PATCH 1/1] irq: add IRQF_TRIGGER_MASK on PPI by default Marc Zyngier <marc.zyngier@arm.com> - 2017-03-31 10:20 +0200
      RE: [PATCH 1/1] irq: add IRQF_TRIGGER_MASK on PPI by default Aniruddha Banerjee <aniruddhab@nvidia.com> - 2017-03-31 14:10 +0200
    Re: [PATCH 1/1] irq: add IRQF_TRIGGER_MASK on PPI by default Jon Hunter <jonathanh@nvidia.com> - 2017-03-31 10:20 +0200

csiph-web