Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1613341

Re: [PATCH][V2] VSOCK: remove unnecessary ternary operator on return value

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH][V2] VSOCK: remove unnecessary ternary operator on return value
Date Thu, 30 Mar 2017 20:20:01 +0200
Message-ID <tqMPT-1Sb-3@gated-at.bofh.it> (permalink)
References <tqnRx-sm-47@gated-at.bofh.it>
X-Original-To colin.king@canonical.com
X-Mailer Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
MIME-Version 1.0
Content-Type Text/Plain; charset=us-ascii
Content-Transfer-Encoding 7bit
X-Greylist Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 30 Mar 2017 10:26:13 -0700 (PDT)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 14
Organization linux.* mail to news gateway
X-Original-Cc jhansen@vmware.com, mst@redhat.com, aditr@vmware.com, georgezhang@vmware.com, stefanha@redhat.com, julia.lawall@lip6.fr, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Thu, 30 Mar 2017 11:07:28 -0700 (PDT)
X-Original-Message-ID <20170330.110728.1080980088987923914.davem@davemloft.net>
X-Original-References <20170329153355.17525-1-colin.king@canonical.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1613341

Show key headers only | View raw


From: Colin King <colin.king@canonical.com>
Date: Wed, 29 Mar 2017 16:33:55 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> Rather than assign the positive errno values to ret and then
> checking if it is positive and flip the sign, just return the
> errno value.
> 
> Detected by CoverityScan, CID#986649 ("Logically Dead Code")
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied to net-next, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH][V2] VSOCK: remove unnecessary ternary operator on return value Colin King <colin.king@canonical.com> - 2017-03-29 17:40 +0200
  Re: [PATCH][V2] VSOCK: remove unnecessary ternary operator on return  value Stefan Hajnoczi <stefanha@redhat.com> - 2017-03-29 20:40 +0200
  Re: [PATCH][V2] VSOCK: remove unnecessary ternary operator on return  value "Jorgen S. Hansen" <jhansen@vmware.com> - 2017-03-30 15:20 +0200
  Re: [PATCH][V2] VSOCK: remove unnecessary ternary operator on return  value "Michael S. Tsirkin" <mst@redhat.com> - 2017-03-30 15:30 +0200
  Re: [PATCH][V2] VSOCK: remove unnecessary ternary operator on  return value David Miller <davem@davemloft.net> - 2017-03-30 20:20 +0200

csiph-web