Re: [PATCH][V2] VSOCK: remove unnecessary ternary operator on return value

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH][V2] VSOCK: remove unnecessary ternary operator on return value
Date	2017-03-30 20:20 +0200
Message-ID	<tqMPT-1Sb-3@gated-at.bofh.it> (permalink)
References	<tqnRx-sm-47@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin King <colin.king@canonical.com>
Date: Wed, 29 Mar 2017 16:33:55 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> Rather than assign the positive errno values to ret and then
> checking if it is positive and flip the sign, just return the
> errno value.
> 
> Detected by CoverityScan, CID#986649 ("Logically Dead Code")
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied to net-next, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH][V2] VSOCK: remove unnecessary ternary operator on return value Colin King <colin.king@canonical.com> - 2017-03-29 17:40 +0200
  Re: [PATCH][V2] VSOCK: remove unnecessary ternary operator on return  value Stefan Hajnoczi <stefanha@redhat.com> - 2017-03-29 20:40 +0200
  Re: [PATCH][V2] VSOCK: remove unnecessary ternary operator on return  value "Jorgen S. Hansen" <jhansen@vmware.com> - 2017-03-30 15:20 +0200
  Re: [PATCH][V2] VSOCK: remove unnecessary ternary operator on return  value "Michael S. Tsirkin" <mst@redhat.com> - 2017-03-30 15:30 +0200
  Re: [PATCH][V2] VSOCK: remove unnecessary ternary operator on  return value David Miller <davem@davemloft.net> - 2017-03-30 20:20 +0200

csiph-web