Re: [PATCH] iio: adc: replace comma with a semicolon

Path	csiph.com!news.redatomik.org!news.albasani.net!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] iio: adc: replace comma with a semicolon
Date	Thu, 30 Mar 2017 15:40:02 +0200
Message-ID	<tqIsW-70Q-29@gated-at.bofh.it> (permalink)
References	<tqHGy-6sD-35@gated-at.bofh.it> <tqIsW-70Q-31@gated-at.bofh.it>
X-Original-To	jacopo <jacopo@jmondi.org>
Dkim-Signature	v=1; a=rsa-sha256; c=simple/simple; d=pmeerw.net; s=mail; t=1490881133; bh=vVIxZmB/FRqOcwIXYwKspbXz2dx9rjX+s4/9gzT9jZs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=QxnGyEtuuDs2b5s1hwuo2NV/BD9b5oa26swavf8s55+6ZsBvYZIqTClcu3UQl2G+V CZHzL8yT4VLN1CiDN99k/+YhufMoZldYZKxsEZQbT4c16mpJ611N+6mfqdtzIWcFT9 koxix9y0fE0O6bN4J+c78inQNrBjU4xVYNX6LGC0=
User-Agent	Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	43
Organization	linux.* mail to news gateway
X-Original-Cc	Arushi Singhal <arushisinghal19971997@gmail.com>, outreachy-kernel@googlegroups.com, Jonathan Cameron <jic23@kernel.org>, Lars-Peter Clausen <lars@metafoo.de>, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Thu, 30 Mar 2017 15:38:53 +0200 (CEST)
X-Original-Message-ID	<alpine.DEB.2.20.1703301534380.24907@vps.pmeerw.net>
X-Original-References	<20170330124603.GA29301@arushi-HP-Pavilion-Notebook> <20170330133046.GA7900@w540>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1613073

Show key headers only | View raw

> On Thu, Mar 30, 2017 at 06:16:03PM +0530, Arushi Singhal wrote:
> > Replace a comma between expression statements by a semicolon. This
> > changes the semantics of the code, but given the current indentation
> > appears to be what is intended.

> You can simply say that this fixes what appears to be a bug to me.
> I wonder how this does even compile..

it's valid C and I think it does the correct thing (i.e. assign those 
variables); the style is weird obviously

> [1] https://marc.info/?l=linux-iio&m=148475728729617&w=2
> 
> > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> > ---
> >  drivers/iio/adc/max11100.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/iio/adc/max11100.c b/drivers/iio/adc/max11100.c
> > index 23c060e1b663..1180bcc22ff1 100644
> > --- a/drivers/iio/adc/max11100.c
> > +++ b/drivers/iio/adc/max11100.c
> > @@ -124,8 +124,8 @@ static int max11100_probe(struct spi_device *spi)
> >  	indio_dev->name = "max11100";
> >  	indio_dev->info = &max11100_info;
> >  	indio_dev->modes = INDIO_DIRECT_MODE;
> > -	indio_dev->channels = max11100_channels,
> > -	indio_dev->num_channels = ARRAY_SIZE(max11100_channels),
> > +	indio_dev->channels = max11100_channels;
> > +	indio_dev->num_channels = ARRAY_SIZE(max11100_channels);
> >  
> >  	state->vref_reg = devm_regulator_get(&spi->dev, "vref");
> >  	if (IS_ERR(state->vref_reg))
> > -- 
> > 2.11.0
> > 
> 

-- 

Peter Meerwald-Stadler
Mobile: +43 664 24 44 418

Thread

[PATCH] iio: adc: replace comma with a semicolon Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-30 14:50 +0200
  Re: [PATCH] iio: adc: replace comma with a semicolon Peter Meerwald-Stadler <pmeerw@pmeerw.net> - 2017-03-30 15:40 +0200
    Re: [PATCH] iio: adc: replace comma with a semicolon Jonathan Cameron <jic23@kernel.org> - 2017-04-01 12:10 +0200
  Re: [PATCH] iio: adc: replace comma with a semicolon jacopo <jacopo@jmondi.org> - 2017-03-30 15:40 +0200
    Re: [PATCH] iio: adc: replace comma with a semicolon Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-03-30 19:30 +0200
      Re: [PATCH] iio: adc: replace comma with a semicolon jacopo <jacopo@jmondi.org> - 2017-03-30 20:10 +0200
  Re: [Outreachy kernel] [PATCH] iio: adc: replace comma with a  semicolon Alison Schofield <amsfield22@gmail.com> - 2017-03-30 20:30 +0200

csiph-web