Re: [RFC v5 5/9] sched/deadline: do not reclaim the whole CPU bandwidth

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [RFC v5 5/9] sched/deadline: do not reclaim the whole CPU bandwidth
Date	2017-03-27 10:40 +0200
Message-ID	<tpylX-5c4-3@gated-at.bofh.it> (permalink)
References	<toh3P-72e-5@gated-at.bofh.it> <toh3P-72e-3@gated-at.bofh.it> <toy4G-2Fu-31@gated-at.bofh.it> <toFpw-7JB-11@gated-at.bofh.it> <toJMt-2y5-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Mar 24, 2017 at 10:38:31PM -0400, Steven Rostedt wrote:

> > > > @@ -6716,6 +6716,12 @@ static void sched_dl_do_global(void)
> > > >  		raw_spin_unlock_irqrestore(&dl_b->lock, flags);
> > > >  
> > > >  		rcu_read_unlock_sched();
> > > > +		if (dl_b->bw == -1)
> > > > +			cpu_rq(cpu)->dl.deadline_bw_inv = 1 << 8;
> > > > +		else
> > > > +			cpu_rq(cpu)->dl.deadline_bw_inv =
> > > > +				to_ratio(global_rt_runtime(),
> > > > +					 global_rt_period()) >>
> > > > 12;    
> > > 
> > > Coding style requires braces here (on both legs of the condition)..  

> I'm not sure it's completely documented anywhere.

Two parts;

 1) I prefer braces over any multi line block, irrespective if its a
 single statement or not. This is, afaik, not strictly documented in
 coding style.

 Rationale is that missing braces are bad, and the larger the single
 statement, the harder it is to be sure it is in fact a single
 statement.

 2) If one leg needs braces, then both should get it. This is in fact
 part of CodingStyle.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC v5 5/9] sched/deadline: do not reclaim the whole CPU bandwidth luca abeni <luca.abeni@santannapisa.it> - 2017-03-23 21:00 +0100
  Re: [RFC v5 5/9] sched/deadline: do not reclaim the whole CPU  bandwidth Peter Zijlstra <peterz@infradead.org> - 2017-03-24 15:10 +0100
    Re: [RFC v5 5/9] sched/deadline: do not reclaim the whole CPU  bandwidth luca abeni <luca.abeni@santannapisa.it> - 2017-03-24 23:00 +0100
      Re: [RFC v5 5/9] sched/deadline: do not reclaim the whole CPU  bandwidth Steven Rostedt <rostedt@goodmis.org> - 2017-03-25 03:40 +0100
        Re: [RFC v5 5/9] sched/deadline: do not reclaim the whole CPU  bandwidth Peter Zijlstra <peterz@infradead.org> - 2017-03-27 10:40 +0200

csiph-web