Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1609400
| From | Ralph Sennhauser <ralph.sennhauser@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan |
| Date | 2017-03-26 23:10 +0200 |
| Message-ID | <tpnAd-5OK-9@gated-at.bofh.it> (permalink) |
| References | <toyen-2LK-59@gated-at.bofh.it> <toyen-2LK-63@gated-at.bofh.it> <toyxH-2SC-5@gated-at.bofh.it> |
| Organization | none |
On Fri, 24 Mar 2017 15:35:05 +0100
Andrew Lunn <andrew@lunn.ch> wrote:
> > + pwm_fan {
> > /* SUNON HA4010V4-0000-C99 */
> > - compatible = "gpio-fan";
> > - gpios = <&gpio0 24 0>;
> >
> > - gpio-fan,speed-map = <0 0
> > - 4500 1>;
> > + compatible = "pwm-fan";
> > + pwms = <&gpio0 24 4000 0>;
>
> Hi Ralph
>
> I believe this last 0 is the flags parameter. Now that we have
> #pwm-cells = 1, i think this last 0 should be dropped.
>
> Andrew
Hi Andrew,
isn't the 4000 (period?) pwm-cell #2 and 0 (flags?) pwm-cell #3? I
actually expect "pwms = <&gpio0 24>;" here or "#pwm-cells = <2>;"
Ralph
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-03-24 15:20 +0100
Re: [PATCH v3 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan Andrew Lunn <andrew@lunn.ch> - 2017-03-24 15:40 +0100
Re: [PATCH v3 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-03-24 23:30 +0100
Re: [PATCH v3 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-03-26 23:10 +0200
Re: [PATCH v3 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan Andrew Lunn <andrew@lunn.ch> - 2017-03-27 15:20 +0200
csiph-web