Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1608491

Re: [PATCH v3 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: [PATCH v3 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan
Date 2017-03-24 15:40 +0100
Message-ID <toyxH-2SC-5@gated-at.bofh.it> (permalink)
References <toyen-2LK-59@gated-at.bofh.it> <toyen-2LK-63@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> +	pwm_fan {
>  		/* SUNON HA4010V4-0000-C99 */
> -		compatible = "gpio-fan";
> -		gpios = <&gpio0 24 0>;
>  
> -		gpio-fan,speed-map = <0    0
> -				      4500 1>;
> +		compatible = "pwm-fan";
> +		pwms = <&gpio0 24 4000 0>;

Hi Ralph

I believe this last 0 is the flags parameter. Now that we have
#pwm-cells = 1, i think this last 0 should be dropped.

	  Andrew

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v3 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-03-24 15:20 +0100
  Re: [PATCH v3 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan Andrew Lunn <andrew@lunn.ch> - 2017-03-24 15:40 +0100
    Re: [PATCH v3 4/4] mvebu: wrt1900ac: Use pwm-fan rather than  gpio-fan Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-03-24 23:30 +0100
    Re: [PATCH v3 4/4] mvebu: wrt1900ac: Use pwm-fan rather than  gpio-fan Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-03-26 23:10 +0200
      Re: [PATCH v3 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan Andrew Lunn <andrew@lunn.ch> - 2017-03-27 15:20 +0200

csiph-web