Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver

Path	csiph.com!news.redatomik.org!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Krzysztof Kozlowski <krzk@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver
Date	Sun, 26 Mar 2017 20:20:02 +0200
Message-ID	<tpkVI-3IL-5@gated-at.bofh.it> (permalink)
References	<toWJH-3l4-3@gated-at.bofh.it> <tpiTU-2gQ-9@gated-at.bofh.it> <tpjwB-2ws-9@gated-at.bofh.it> <tpjPY-2ZE-11@gated-at.bofh.it>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=X/1IetnV3T2UbJQj/EPSv3NFzT+jM4fgwRNJgtcJ2UU=; b=R0EhzP6GNIQAB/ZjJFHYOfx6BRnBk13A910Xa6WGh5pBO0g3kZGGCI4I2mIpSGQLQb uWDPDIcuU0EFRzRYRBY6RlChZCczdq0Yhg4+NDG6TMKUb1TCwHtKJp4lf0EhoCxEMJAq zim4u6uCq7RGyQzoLNJZitpPuNEb6b8/k36WHNii7eG2lsKPLSwxKk57aH8JUtoTOTZf BYHNn5IVj5DJUMXE2lqheWcYrsA4K7Kba4Aksq78mVeXDqN5sT+4Qa8obJu8zY0BQ0d4 nEQ0Cvt/3D4VpW+nij2mDkJu4ZZkdlEhPiGsB2hwscLe8Y06hKajegxlbQYBh3aF//DR FRxQ==
X-Gm-Message-State	AFeK/H2SoiChNSgIH4z8XNwHGfmQUYRxWAuppu0pWd+AVQDVz8vYQBUwynkEXPlEA37ZBA==
X-Received	by 10.223.153.108 with SMTP id x99mr12726783wrb.55.1490551805674; Sun, 26 Mar 2017 11:10:05 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Disposition	inline
Content-Transfer-Encoding	8BIT
User-Agent	Mutt/1.6.2-neo (2016-08-21)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	26
Organization	linux.* mail to news gateway
X-Original-Cc	PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>, Kukjin Kim <kgene@kernel.org>, Javier Martinez Canillas <javier@osg.samsung.com>, Matt Mackall <mpm@selenic.com>, Herbert Xu <herbert@gondor.apana.org.au>, "David S. Miller" <davem@davemloft.net>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-crypto@vger.kernel.org, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>
X-Original-Date	Sun, 26 Mar 2017 21:09:59 +0300
X-Original-Message-ID	<20170326180959.rmps6pj5376l45fz@kozik-lap>
X-Original-References	<20170325162654.3827-1-krzk@kernel.org> <20170326160126.nwboar7mwztwxtgp@kozik-lap> <CANc+2y4xkDs2kQGXKP=8i_v9oYw4dPKTjWs0xFnvOcwDbar47g@mail.gmail.com> <1535446.zHpTqe8jba@positron.chronox.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1609376

Show key headers only | View raw

On Sun, Mar 26, 2017 at 07:05:48PM +0200, Stephan Müller wrote:
> Am Sonntag, 26. März 2017, 18:46:02 CEST schrieb PrasannaKumar Muralidharan:
> 
> Hi 	Krzysztof,
> 
> > >> > +       if (slen < EXYNOS_RNG_SEED_SIZE) {
> > >> > +               dev_warn(rng->dev, "Seed too short (only %u bytes)\n",
> > >> > slen); +               return -EINVAL;
> > >> > +       }
> > >> 
> > >> Will it be helpful to print the required seed size?
> > > 
> > > It is in /proc/crypto... It is not a problem to print it but isn't that
> > > redundant?
> > 
> > Not necessary if it is already available.
> 
> Maybe the dev_warn should be removed. Note, unprivileged user space can 
> trigger this warning by simply invoking the seeding operation over and over 
> again with an insufficient seed size. This would clutter the log.

Makes sense. The generic dev_dbg() before would bring enough
information.

Best regards,
Krzysztof

Thread

[PATCH v3 0/3] crypto: hw_random - Add new Exynos RNG driver Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-25 17:30 +0100
  [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-25 17:30 +0100
    Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> - 2017-03-26 17:40 +0200
      Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-26 18:10 +0200
        Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver Stephan Müller <smueller@chronox.de> - 2017-03-26 18:20 +0200
        Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> - 2017-03-26 18:50 +0200
          Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver Stephan Müller <smueller@chronox.de> - 2017-03-26 19:10 +0200
            Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-26 20:20 +0200
    Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver Stephan Müller <smueller@chronox.de> - 2017-03-26 19:20 +0200
      Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-26 20:10 +0200
        Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver Stephan Müller <smueller@chronox.de> - 2017-03-26 23:30 +0200
          Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> - 2017-03-27 06:30 +0200
            Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver Stephan Müller <smueller@chronox.de> - 2017-03-27 16:00 +0200
  Re: [PATCH v3 0/3] crypto: hw_random - Add new Exynos RNG driver Stephan Müller <smueller@chronox.de> - 2017-03-25 17:40 +0100

csiph-web