Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1609357

Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver

From Stephan Müller <smueller@chronox.de>
Newsgroups linux.kernel
Subject Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver
Date 2017-03-26 19:10 +0200
Message-ID <tpjPY-2ZE-11@gated-at.bofh.it> (permalink)
References <toWJH-3l4-3@gated-at.bofh.it> <tpiTU-2gQ-9@gated-at.bofh.it> <tpjwB-2ws-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Am Sonntag, 26. März 2017, 18:46:02 CEST schrieb PrasannaKumar Muralidharan:

Hi 	Krzysztof,

> >> > +       if (slen < EXYNOS_RNG_SEED_SIZE) {
> >> > +               dev_warn(rng->dev, "Seed too short (only %u bytes)\n",
> >> > slen); +               return -EINVAL;
> >> > +       }
> >> 
> >> Will it be helpful to print the required seed size?
> > 
> > It is in /proc/crypto... It is not a problem to print it but isn't that
> > redundant?
> 
> Not necessary if it is already available.

Maybe the dev_warn should be removed. Note, unprivileged user space can 
trigger this warning by simply invoking the seeding operation over and over 
again with an insufficient seed size. This would clutter the log.

Ciao
Stephan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/3] crypto: hw_random - Add new Exynos RNG driver Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-25 17:30 +0100
  [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-25 17:30 +0100
    Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> - 2017-03-26 17:40 +0200
      Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-26 18:10 +0200
        Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver Stephan Müller <smueller@chronox.de> - 2017-03-26 18:20 +0200
        Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> - 2017-03-26 18:50 +0200
          Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver Stephan Müller <smueller@chronox.de> - 2017-03-26 19:10 +0200
            Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-26 20:20 +0200
    Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver Stephan Müller <smueller@chronox.de> - 2017-03-26 19:20 +0200
      Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-26 20:10 +0200
        Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver Stephan Müller <smueller@chronox.de> - 2017-03-26 23:30 +0200
          Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> - 2017-03-27 06:30 +0200
            Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver Stephan Müller <smueller@chronox.de> - 2017-03-27 16:00 +0200
  Re: [PATCH v3 0/3] crypto: hw_random - Add new Exynos RNG driver Stephan Müller <smueller@chronox.de> - 2017-03-25 17:40 +0100

csiph-web