Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1610613
| From | John Garry <john.garry@huawei.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] scsi: hisi_sas: add missing break in switch statement |
| Date | 2017-03-28 13:50 +0200 |
| Message-ID | <tpXNo-6Vx-5@gated-at.bofh.it> (permalink) |
| References | <tpXkl-6JL-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 28/03/2017 12:12, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> It appears that a break in the TRANS_TX_OPEN_CNX_ERR_NO_DESTINATION
> case got accidentally removed in an earlier commit, as it stands,
> the ts->stat and ts->open_rej_reason are being updated twice for this
> case which looks incorrect. Fix this by adding in the missing break
> statement.
>
> Detected by CoverityScan, CID#1422110 ("Missing break in switch")
>
> Fixes: 634a9585f49c7 ("scsi: hisi_sas: process error codes according to their priority")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, checkpatch.pl would normally catch this but it was hidden in the
formatted patch
Signed-off-by: John Garry <john.garry@huawei.com>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] scsi: hisi_sas: add missing break in switch statement Colin King <colin.king@canonical.com> - 2017-03-28 13:20 +0200 Re: [PATCH] scsi: hisi_sas: add missing break in switch statement John Garry <john.garry@huawei.com> - 2017-03-28 13:50 +0200 Re: [PATCH] scsi: hisi_sas: add missing break in switch statement "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-03-30 04:50 +0200
csiph-web