Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1610388

Re: memory hotplug and force_remove

Show all headers | View raw

On Mon 20-03-17 22:24:42, Rafael J. Wysocki wrote:
> On Monday, March 20, 2017 03:29:39 PM Michal Hocko wrote:
> > Hi Rafael,
> 
> Hi,
> 
> > we have been chasing the following BUG() triggering during the memory
> > hotremove (remove_memory):
> > 	ret = walk_memory_range(PFN_DOWN(start), PFN_UP(start + size - 1), NULL,
> > 				check_memblock_offlined_cb);
> > 	if (ret)
> > 		BUG();
> > 
> > and it took a while to learn that the issue is caused by
> > /sys/firmware/acpi/hotplug/force_remove being enabled. I was really
> > surprised to see such an option because at least for the memory hotplug
> > it cannot work at all. Memory hotplug fails when the memory is still
> > in use. Even if we do not BUG() here enforcing the hotplug operation
> > will lead to problematic behavior later like crash or a silent memory
> > corruption if the memory gets onlined back and reused by somebody else.
> > 
> > I am wondering what was the motivation for introducing this behavior and
> > whether there is a way to disallow it for memory hotplug. Or maybe drop
> > it completely. What would break in such a case?
> 
> Honestly, I don't remember from the top of my head and I haven't looked at
> that code for several months.
> 
> I need some time to recall that.

Did you have any chance to look into this?
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

memory hotplug and force_remove Michal Hocko <mhocko@kernel.org> - 2017-03-20 20:40 +0100
  Re: memory hotplug and force_remove "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-20 22:40 +0100
    Re: memory hotplug and force_remove joeyli <jlee@suse.com> - 2017-03-21 17:20 +0100
    Re: memory hotplug and force_remove Michal Hocko <mhocko@kernel.org> - 2017-03-28 10:00 +0200
      Re: memory hotplug and force_remove "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-28 17:30 +0200
        Re: memory hotplug and force_remove Jiri Kosina <jikos@kernel.org> - 2017-03-30 11:00 +0200
          Re: memory hotplug and force_remove Michal Hocko <mhocko@kernel.org> - 2017-03-30 18:30 +0200
            Re: memory hotplug and force_remove joeyli <jlee@suse.com> - 2017-03-30 19:00 +0200
              Re: memory hotplug and force_remove "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-03-30 22:30 +0200
                Re: memory hotplug and force_remove joeyli <jlee@suse.com> - 2017-03-31 02:10 +0200
        Re: memory hotplug and force_remove Michal Hocko <mhocko@kernel.org> - 2017-03-31 10:40 +0200
          Re: memory hotplug and force_remove Michal Hocko <mhocko@kernel.org> - 2017-03-31 13:00 +0200
            Re: memory hotplug and force_remove joeyli <jlee@suse.com> - 2017-03-31 14:00 +0200
              Re: memory hotplug and force_remove Michal Hocko <mhocko@kernel.org> - 2017-03-31 14:10 +0200
                Re: memory hotplug and force_remove "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-04-01 00:50 +0200
          Re: memory hotplug and force_remove joeyli <jlee@suse.com> - 2017-03-31 13:00 +0200

csiph-web