[PATCH v6 0/5] i2c: aspeed: added driver for Aspeed I2C

Path	csiph.com!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From	Brendan Higgins <brendanhiggins@google.com>
Newsgroups	linux.kernel
Subject	[PATCH v6 0/5] i2c: aspeed: added driver for Aspeed I2C
Date	Tue, 28 Mar 2017 07:20:01 +0200
Message-ID	<tpRHX-2LM-3@gated-at.bofh.it> (permalink)
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=nGfAkbklk1F2d3ov73vw6UNiHw+vQ0SEPC5pCxk2dNA=; b=uONm+xtvwGQNTyEGEIfbC4/FDFTrIz+w8FcjxuvVyPireaDEBAO9lv0hI4pFCgg1w+ nM+MHE4npFOmUCmLUr/MXACwxW08Hrd1lBVrcVHDjjis0uOq1Bi4CIOCgN/qTrXVWxcU VBSS804uvbCJhnZvdU+SYBAn1fa6YLgknGjvsgVmXXHTdKD6opplLxR0VG7Ba72+V3dX gmXCbKkNXTYB8vpSzrF+EXEHVEqMADEKTW87tSPlSoAB5s5OmlovxYZaithI5RcHhVAu e2hSEYGvkr55lu8J2H2hc0aZoJEyTJ5k7s+TzYRR3OyLq1GC0xuAmVUW+loFwkd/rlHL 6l6Q==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=nGfAkbklk1F2d3ov73vw6UNiHw+vQ0SEPC5pCxk2dNA=; b=bWu4bbpf1PVuESlzZNZEdTGNLC6gdpnbl/AEyoSZfrzmTNfTbcaXyfJ/ZJqVH3rlni i9W8zwV6J3yhjyE3rRMDAEIe8xAc11FLW6XMaZXPlTeW7dCsJWaLwpgnSu3J+VM62w4l fAkuTesTyYbVXjibhbAsvN5u6lV5WewuQdL3JTzpnwzM2/+xRaDbgjhZqxXIcSFdmI28 dAi1R6uBLHTt09qjgCkN4KBa+kIKA6cTODuOcQsRfzqRyq6T7vd62AdbFqPlMqqnId5F V3K1peDrr3VzK2MB5jDWA2m8LjJQMgDUypVHo8MYwLVMbYQo04VOFT+pU1BBPluQvLWq rUzw==
X-Gm-Message-State	AFeK/H3tcdTEL6TLZ9ToXBdEAC5XadlT6eU2p8YNXSQ1ax4U4EPoi7DqynYJWGGHckS/hQ7S
X-Received	by 10.84.241.139 with SMTP id b11mr26968371pll.107.1490677967166; Mon, 27 Mar 2017 22:12:47 -0700 (PDT)
X-Mailer	git-send-email 2.12.2.564.g063fe858b8-goog
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	34
Organization	linux.* mail to news gateway
X-Original-Cc	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, benh@kernel.crashing.org
X-Original-Date	Mon, 27 Mar 2017 22:12:21 -0700
X-Original-Message-ID	<20170328051226.21677-1-brendanhiggins@google.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1610300

Show key headers only | View raw

Sorry for the delay, I went on a long vacation prior to receiving feedback and
got back in the middle of a hardware bring up that consumed all of my attention
for an extended period of time. I will try to plan upstream submissions around
my other responsibilities better in the future.

Addressed comments from:
  - Vladimir in: https://www.spinics.net/lists/linux-i2c/msg27387.html
    and: https://www.spinics.net/lists/linux-i2c/msg27386.html
  - Wolfram in: https://www.spinics.net/lists/linux-i2c/msg27476.html
    and: https://www.spinics.net/lists/linux-i2c/msg27483.html

Changes since previous update:
  - No longer arbitrarily restrict bus to be slave xor master.
  - Pulled out "struct aspeed_i2c_controller" as a interrupt controller.
  - Pulled out slave support into its own commit.
  - Rewrote code that sets clock divider register because the original version
    set it incorrectly.
  - Discovered and fixed issue in implementation that caused certain slave
    devices to misbehave; the cause was that the master IRQ handler would return
    control to the requesting thread after the last RX or TX command was handled
    such that the requesting thread would issue either a repeated start or stop.
    This was incorrect because the time taken to complete the completion was too
    great. I fixed this by rewriting the master IRQ handler so that it now
    manages the entire transaction only returning control to the requesting
    thread once the entire transaction is complete.
  - Rewrote the aspeed_i2c_master_irq handler because the old method of
    completing a completion in between restarts was too slow causing devices to
    misbehave.
  - Added support for I2C_M_RECV_LEN which I had incorrectly said was supported
    before.
  - Addressed other comments from Vladimir.

Changes have been tested on the Aspeed 2500 evaluation board, as before, and now
on a real platform with an Aspeed 2520.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v6 0/5] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins <brendanhiggins@google.com> - 2017-03-28 07:20 +0200
  [PATCH v6 3/5] i2c: aspeed: added documentation for Aspeed I2C driver Brendan Higgins <brendanhiggins@google.com> - 2017-03-28 07:20 +0200
    Re: [PATCH v6 3/5] i2c: aspeed: added documentation for Aspeed I2C  driver Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2017-03-28 11:00 +0200
      Re: [PATCH v6 3/5] i2c: aspeed: added documentation for Aspeed I2C driver Brendan Higgins <brendanhiggins@google.com> - 2017-03-29 12:30 +0200
      Re: [PATCH v6 3/5] i2c: aspeed: added documentation for Aspeed I2C  driver Rob Herring <robh@kernel.org> - 2017-04-03 16:30 +0200
    Re: [PATCH v6 3/5] i2c: aspeed: added documentation for Aspeed I2C  driver Rob Herring <robh@kernel.org> - 2017-04-03 16:30 +0200
  [PATCH v6 5/5] i2c: aspeed: added slave support for Aspeed I2C driver Brendan Higgins <brendanhiggins@google.com> - 2017-03-28 07:20 +0200
  Re: [PATCH v6 0/5] i2c: aspeed: added driver for Aspeed I2C Andrew Jeffery <andrew@aj.id.au> - 2017-03-31 02:10 +0200

csiph-web