Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1615243
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v6 3/5] i2c: aspeed: added documentation for Aspeed I2C driver |
| Date | 2017-04-03 16:30 +0200 |
| Message-ID | <tsb9w-80W-5@gated-at.bofh.it> (permalink) |
| References | <tpRHX-2LM-3@gated-at.bofh.it> <tpRHX-2LM-11@gated-at.bofh.it> <tpV8S-535-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Mar 28, 2017 at 07:54:43PM +1100, Benjamin Herrenschmidt wrote:
> On Mon, 2017-03-27 at 22:12 -0700, Brendan Higgins wrote:
> > Added device tree binding documentation for Aspeed I2C busses.
> >
> > Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
>
> > + i2c0: i2c-bus@40 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + #interrupt-cells = <1>;
> > + reg = <0x40 0x40>;
> > + compatible = "aspeed,ast2400-i2c-bus";
> > + bus = <0>;
> > + clocks = <&clk_apb>;
> > + clock-frequency = <100000>;
>
> For busses it's more traditional to make this "bus-frequency" but
> that's a nit and Linux/fdt has not respected that tradition terribly
> well. If you respin, it might be work changing.
Makes sense, but that's news to me. I'm still new to this DT stuff.
> The clock-frequency tends to be the frequency of the controller itself.
The clock binding has largely replaced that.
Rob
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v6 0/5] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins <brendanhiggins@google.com> - 2017-03-28 07:20 +0200
[PATCH v6 3/5] i2c: aspeed: added documentation for Aspeed I2C driver Brendan Higgins <brendanhiggins@google.com> - 2017-03-28 07:20 +0200
Re: [PATCH v6 3/5] i2c: aspeed: added documentation for Aspeed I2C driver Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2017-03-28 11:00 +0200
Re: [PATCH v6 3/5] i2c: aspeed: added documentation for Aspeed I2C driver Brendan Higgins <brendanhiggins@google.com> - 2017-03-29 12:30 +0200
Re: [PATCH v6 3/5] i2c: aspeed: added documentation for Aspeed I2C driver Rob Herring <robh@kernel.org> - 2017-04-03 16:30 +0200
Re: [PATCH v6 3/5] i2c: aspeed: added documentation for Aspeed I2C driver Rob Herring <robh@kernel.org> - 2017-04-03 16:30 +0200
[PATCH v6 5/5] i2c: aspeed: added slave support for Aspeed I2C driver Brendan Higgins <brendanhiggins@google.com> - 2017-03-28 07:20 +0200
Re: [PATCH v6 0/5] i2c: aspeed: added driver for Aspeed I2C Andrew Jeffery <andrew@aj.id.au> - 2017-03-31 02:10 +0200
csiph-web