Re: [PATCH 1/2] selftests: fix the broken individual test for x86

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Michael Ellerman <mpe@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] selftests: fix the broken individual test for x86
Date	Tue, 28 Mar 2017 02:30:02 +0200
Message-ID	<tpNbk-7QT-9@gated-at.bofh.it> (permalink)
References	<tpvR8-3fY-7@gated-at.bofh.it> <tpvR9-3fY-25@gated-at.bofh.it>
X-Original-To	Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>, luto@amacapital.net, shuahkh@osg.samsung.com
User-Agent	Notmuch/0.21 (https://notmuchmail.org)
MIME-Version	1.0
Content-Type	text/plain
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	28
Organization	linux.* mail to news gateway
X-Original-Cc	linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, khilman@kernel.org, broonie@kernel.org, bamvor.zhangjian@huawei.com, bamvor.zhangjian@linaro.org
X-Original-Date	Tue, 28 Mar 2017 11:22:53 +1100
X-Original-Message-ID	<87bmsm8d2a.fsf@concordia.ellerman.id.au>
X-Original-References	<20170327054601.22415-1-bamvor.zhangjian@linaro.org> <20170327054601.22415-2-bamvor.zhangjian@linaro.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1610178

Show key headers only | View raw

Bamvor Jian Zhang <bamvor.zhangjian@linaro.org> writes:

> Andy Lutomirski report that build individual testcase in x86 is broken:
>
> $ make -C tools/testing/selftests/x86 ldt_gdt_32
> make: Entering directory '/home/luto/apps/linux/tools/testing/selftests/x86'
> Makefile:44: warning: overriding recipe for target 'clean'
> ../lib.mk:55: warning: ignoring old recipe for target 'clean'
> make: *** No rule to make target 'ldt_gdt_32'.  Stop.
> make: Leaving directory '/home/luto/apps/linux/tools/testing/selftests/x86'
>
> This patch fix this issue by adding default OUTPUT and convert
> target in Makefile of x86.
>
> And also mention this use case in Documentation/kselftests.txt
>
> Reported-by: Andy Lutomirski <luto@amacapital.net>
> Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>
> ---
>  Documentation/kselftest.txt          |  6 ++++++
>  tools/testing/selftests/x86/Makefile | 23 ++++++++++++++---------
>  2 files changed, 20 insertions(+), 9 deletions(-)

I don't think this is a good fix, it only fixes this one Makefile, and
it's quite verbose. But if it really bothers Andy then it would be OK as
a stop-gap for 4.11.

cheers

Thread

[PATCH 0/2] selftests: fix for KBUILD_OUTPUT Bamvor Jian Zhang <bamvor.zhangjian@linaro.org> - 2017-03-27 08:00 +0200
  [PATCH 2/2] selftests: net: support KBUILD_OUTPUT for reuseport_bpf_numa Bamvor Jian Zhang <bamvor.zhangjian@linaro.org> - 2017-03-27 08:00 +0200
  [PATCH 1/2] selftests: fix the broken individual test for x86 Bamvor Jian Zhang <bamvor.zhangjian@linaro.org> - 2017-03-27 08:00 +0200
    Re: [PATCH 1/2] selftests: fix the broken individual test for x86 Michael Ellerman <mpe@ellerman.id.au> - 2017-03-28 02:30 +0200
      Re: [PATCH 1/2] selftests: fix the broken individual test for x86 Bamvor Zhang Jian <bamvor.zhangjian@linaro.org> - 2017-03-28 13:40 +0200

csiph-web