Re: [PATCH 1/2] selftests: fix the broken individual test for x86

From	Bamvor Zhang Jian <bamvor.zhangjian@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] selftests: fix the broken individual test for x86
Date	2017-03-28 13:40 +0200
Message-ID	<tpXDH-6Qq-1@gated-at.bofh.it> (permalink)
References	<tpvR8-3fY-7@gated-at.bofh.it> <tpvR9-3fY-25@gated-at.bofh.it> <tpNbk-7QT-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi, Michael

On 28 March 2017 at 08:22, Michael Ellerman <mpe@ellerman.id.au> wrote:
> Bamvor Jian Zhang <bamvor.zhangjian@linaro.org> writes:
>
>> Andy Lutomirski report that build individual testcase in x86 is broken:
>>
>> $ make -C tools/testing/selftests/x86 ldt_gdt_32
>> make: Entering directory '/home/luto/apps/linux/tools/testing/selftests/x86'
>> Makefile:44: warning: overriding recipe for target 'clean'
>> ../lib.mk:55: warning: ignoring old recipe for target 'clean'
>> make: *** No rule to make target 'ldt_gdt_32'.  Stop.
>> make: Leaving directory '/home/luto/apps/linux/tools/testing/selftests/x86'
>>
>> This patch fix this issue by adding default OUTPUT and convert
>> target in Makefile of x86.
>>
>> And also mention this use case in Documentation/kselftests.txt
>>
>> Reported-by: Andy Lutomirski <luto@amacapital.net>
>> Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>
>> ---
>>  Documentation/kselftest.txt          |  6 ++++++
>>  tools/testing/selftests/x86/Makefile | 23 ++++++++++++++---------
>>  2 files changed, 20 insertions(+), 9 deletions(-)
>
> I don't think this is a good fix, it only fixes this one Makefile, and
> it's quite verbose. But if it really bothers Andy then it would be OK as
> a stop-gap for 4.11.
Thanks for review.
Do you mean check this issue in other directory? I plan to do it.
Currently, the x86/Makefile do not use the TEST_GEN_XXX, so
if we found a better fix, we could convert x86/Makefile later.

Regards

Bamvor
>
> cheers
> --
> To unsubscribe from this list: send the line "unsubscribe linux-api" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] selftests: fix the broken individual test for x86 Michael Ellerman <mpe@ellerman.id.au> - 2017-03-28 02:30 +0200
  Re: [PATCH 1/2] selftests: fix the broken individual test for x86 Bamvor Zhang Jian <bamvor.zhangjian@linaro.org> - 2017-03-28 13:40 +0200

csiph-web