Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1610164
| Path | csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | YUAN Linyu <Linyu.Yuan@alcatel-sbell.com.cn> |
| Newsgroups | linux.kernel |
| Subject | RE: [PATCH] usb: gadget: udc: remove redundant initial assignments to the pointer 's' |
| Date | Tue, 28 Mar 2017 01:40:01 +0200 |
| Message-ID | <tpMoV-7gK-5@gated-at.bofh.it> (permalink) |
| References | <tpLsS-6yQ-19@gated-at.bofh.it> |
| X-Original-To | Colin King <colin.king@canonical.com>, Felipe Balbi <balbi@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Bhumika Goyal <bhumirks@gmail.com>, Michal Nazarewicz <mina86@mina86.com>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org> |
| X-Auditid | ac189297-f79916d000005dfd-7f-58d9a226af31 |
| Thread-Topic | [PATCH] usb: gadget: udc: remove redundant initial assignments to the pointer 's' |
| Thread-Index | AQHSp0pV34RS6xaaGUmAN0TIPsDaZaGpVrxg |
| Accept-Language | zh-CN, en-US |
| Content-Language | en-US |
| X-Originating-IP | [135.251.10.22] |
| Content-Type | text/plain; charset="utf-8" |
| Content-Transfer-Encoding | base64 |
| MIME-Version | 1.0 |
| X-Brightmail-Tracker | H4sIAAAAAAAAA+NgFjrAIsWRmVeSWpSXmKPExsXS/tvIXVdt0c0Ig7ZTihbH2p6wW3y6189m 8Xt1L5tF8+L1bBZbb0lbXN41h81i0bJWZosFx1tYHTg8ZjX0snnsnHWX3WPTqk42j/1z17B7 rPvzisnj8ya5ALYoLpuU1JzMstQifbsEroybzQdZCo6IVNxpS21gbBDpYuTkkBAwkZi8bCYb hC0mceHeeiCbi0NI4A6jxJeps1khnG2MEi/vzmDqYuTgYBMwkvjWLgoSFxFoZZJ4u+c5WBGz QAejxII775hARgkLJEpsWjSfGcQWEUiSeDPtJTNIswhQ8//ftiBhFgFViSUXzrCA2LwCjhK9 S8+yg5QICdhKtM11BAlzCthJzPz+HWwio4CsxLRH98FsZgFxiVtP5jNBHC0gsWTPeWYIW1Ti 5eN/rBC2osTGM5tZQUYyC2hKrN+lD9GqKDGl+yE7xFZBiZMzn7BMYBSbhWTqLISOWUg6ZiHp WMDIsopRITmvOCOrODczz8BYLzEnObEkNUe3OCk1J0cvOT9XLzlvEyMwXtdITJq+g/HYAe9D jAIcjEo8vBd4bkYIsSaWFVfmHmKU4GBWEuF90goU4k1JrKxKLcqPLyrNSS0+xCjNwaIkzlu8 ZH+EkEA60Ozs1NSC1CKYLBMHp1QDY229f63Of07m2w82b/Xw7fGf+nvZswkzbz4wli2amq4W prxKdOLW70eEZB+XtJQ2z9v8vG6p4Z/bCmZ9Qi1zeNxdGMs2W4stSd0ia1hwaONKrsYriisv PzBkP5I7w7ynNDvD8Or8799uRU7/JTp9+VLve4/+nX6W7d8UIlUyo3pV0Jndx2Ul1iixFGck GmoxFxUnAgCknm+s0wIAAA== |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 34 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> |
| X-Original-Date | Mon, 27 Mar 2017 23:37:09 +0000 |
| X-Original-Message-ID | <8729016553E3654398EA69218DA29EEF15B7401B@cnshjmbx02> |
| X-Original-References | <20170327223439.10063-1-colin.king@canonical.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1610164 |
Show key headers only | View raw
Hi,
> -----Original Message-----
> From: Colin King [mailto:colin.king@canonical.com]
> Sent: Tuesday, March 28, 2017 6:35 AM
> To: Felipe Balbi; Greg Kroah-Hartman; YUAN Linyu; Bhumika Goyal; Michal
> Nazarewicz; linux-usb@vger.kernel.org
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] usb: gadget: udc: remove redundant initial assignments to the
> pointer 's'
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The initial setting of pointer s to the driver name or to the literal
> string "(none)" is redundant as later it is always set to point to
> a different literal string before it is printed log. Remove this
> redundant code.
>
> Detected with CoverityScan, CID#1227032, CID#1227033 ("Unused Value")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/usb/gadget/udc/net2272.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/net2272.c
> b/drivers/usb/gadget/udc/net2272.c
> index 8f85a51bd2b3..dee4eb60d4c2 100644
> --- a/drivers/usb/gadget/udc/net2272.c
> +++ b/drivers/usb/gadget/udc/net2272.c
> @@ -1191,11 +1191,6 @@ registers_show(struct device *_dev, struct
> device_attribute *attr, char *buf)
> size = PAGE_SIZE;
> spin_lock_irqsave(&dev->lock, flags);
>
> - if (dev->driver)
> - s = dev->driver->driver.name;
> - else
> - s = "(none)";
> -
> /* Main Control Registers */
> t = scnprintf(next, size, "%s version %s,"
> "chiprev %02x, locctl %02x\n"
I think it's original purpose is not use driver_name directly in below scnprintf function call.
You can change drivers_name below to s.
/* Main Control Registers */
t = scnprintf(next, size, "%s version %s,"
"chiprev %02x, locctl %02x\n"
"irqenb0 %02x irqenb1 %02x "
"irqstat0 %02x irqstat1 %02x\n",
driver_name, driver_vers, dev->chiprev,
> --
> 2.11.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] usb: gadget: udc: remove redundant initial assignments to the pointer 's' Colin King <colin.king@canonical.com> - 2017-03-28 00:40 +0200 RE: [PATCH] usb: gadget: udc: remove redundant initial assignments to the pointer 's' YUAN Linyu <Linyu.Yuan@alcatel-sbell.com.cn> - 2017-03-28 01:40 +0200 Re: [PATCH] usb: gadget: udc: remove redundant initial assignments to the pointer 's' Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-03-28 12:30 +0200
csiph-web