Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1610129

[PATCH] usb: gadget: udc: remove redundant initial assignments to the pointer 's'

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

The initial setting of pointer s to the driver name or to the literal
string "(none)" is redundant as later it is always set to point to
a different literal string before it is printed log.  Remove this
redundant code.

Detected with CoverityScan, CID#1227032, CID#1227033 ("Unused Value")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/usb/gadget/udc/net2272.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c
index 8f85a51bd2b3..dee4eb60d4c2 100644
--- a/drivers/usb/gadget/udc/net2272.c
+++ b/drivers/usb/gadget/udc/net2272.c
@@ -1191,11 +1191,6 @@ registers_show(struct device *_dev, struct device_attribute *attr, char *buf)
 	size = PAGE_SIZE;
 	spin_lock_irqsave(&dev->lock, flags);
 
-	if (dev->driver)
-		s = dev->driver->driver.name;
-	else
-		s = "(none)";
-
 	/* Main Control Registers */
 	t = scnprintf(next, size, "%s version %s,"
 		"chiprev %02x, locctl %02x\n"
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb: gadget: udc:  remove redundant initial assignments to the pointer 's' Colin King <colin.king@canonical.com> - 2017-03-28 00:40 +0200
  RE: [PATCH] usb: gadget: udc:  remove redundant initial assignments  to the pointer 's' YUAN Linyu <Linyu.Yuan@alcatel-sbell.com.cn> - 2017-03-28 01:40 +0200
  Re: [PATCH] usb: gadget: udc: remove redundant initial assignments to  the pointer 's' Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-03-28 12:30 +0200

csiph-web