Re: [PATCH] blkcg: allocate struct blkcg_gq outside request queue spinlock

Path	csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Tahsin Erdogan <tahsin@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] blkcg: allocate struct blkcg_gq outside request queue spinlock
Date	Mon, 27 Mar 2017 20:40:01 +0200
Message-ID	<tpHIB-3SI-13@gated-at.bofh.it> (permalink)
References	<tpe3T-773-3@gated-at.bofh.it>
X-Original-To	Julia Lawall <julia.lawall@lip6.fr>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=G+7GWmLkwv8Mpy97vN9tEy86vHpdZqnlnY8aUQeul6E=; b=EYHqd/aIPrst35IlECun05qsjT+54t8KDPMkQF3kKPC5pzPJYUITgA1d8Uu3qSfbpA Do3MB0s36TqesukWctVYKS3MViBm7zkFmdP0uuUyxeOxEvGL0JKs7x/NnHUV/WofS4iz Uu4JjffS6qQutAoyhZxfIcDcwZm+5BtGJ1hvBIvdUguEkDPtByo9excGJ6VWyBVb1ZEU IVjAxkcm0MK4T5/xt3gKRhzpqOJTk8YCiqN07QMweKrHEw2PlVsX4wcwHqGUmggc1tqM jg/GIkOYxX4CkX8S9XeUMCQeWcfDTSeZ8siNyBo9rVzpbYhVl2OVyjgEhk7+30CNY1Rp jh1w==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=G+7GWmLkwv8Mpy97vN9tEy86vHpdZqnlnY8aUQeul6E=; b=b6WBR72ER8U32d9R97gMFsOquSdfjSe9knZzAKLQqzRg4R4I9LNvTnmNuGGjV2ZMaa Br66ySVosl2d5g5WhLeVybu4KNWAfLm2/D6dkBOGqi49sLdAon/FIdErqdaimXPMzABm qbc05/38wEa7BYn84r2oP8zhczHd8sUC5nqv0F1eEpv+ulqambmeDMGghiKtInT3tQVE mZVnP8IHnj2wGGQcvy/nc/oH40ZGVUUnPEtAPWw1lz/Hm6NzpR/dJMZP/mSODlue7447 X1L8FmaEDdgJL2lj8p+C9v4PD7A9VeBnrHjelTSHP8rJ3wJ/3+NiZILmn3pkW5UjhzQl Noog==
X-Gm-Message-State	AFeK/H2ZNdHKuSorTxPUUOMMedLmhvdBHn1xanaao8ZH7/uKhWWdqHxuZqsadwPx6W8KwIR5BXafytwheraQhCqv
X-Received	by 10.107.13.11 with SMTP id 11mr28024587ion.226.1490639359042; Mon, 27 Mar 2017 11:29:19 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	9
Organization	linux.* mail to news gateway
X-Original-Cc	Tejun Heo <tj@kernel.org>, Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org, David Rientjes <rientjes@google.com>, linux-kernel@vger.kernel.org
X-Original-Date	Mon, 27 Mar 2017 11:29:18 -0700
X-Original-Message-ID	<CAAeU0aMQwEQ=URKGaJHxNb81w3BfAysNJkmgmo_+cXVLCrbAxw@mail.gmail.com>
X-Original-References	<alpine.DEB.2.20.1703261252310.2204@hadrien>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1610064

Show key headers only | View raw

On Sun, Mar 26, 2017 at 3:54 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> Is an unlock needed before line 848?  Or does blkg_lookup_check take care
> of it?

Unlock is not needed. On success, function returns with locks held.
It is documented at line 805:

"... This function returns with RCU read
 * lock and queue lock held and must be paired with blkg_conf_finish()."

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] blkcg: allocate struct blkcg_gq outside request queue  spinlock Julia Lawall <julia.lawall@lip6.fr> - 2017-03-26 13:00 +0200
  Re: [PATCH] blkcg: allocate struct blkcg_gq outside request queue spinlock Tahsin Erdogan <tahsin@google.com> - 2017-03-27 20:40 +0200

csiph-web