Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1610064

Re: [PATCH] blkcg: allocate struct blkcg_gq outside request queue spinlock

From Tahsin Erdogan <tahsin@google.com>
Newsgroups linux.kernel
Subject Re: [PATCH] blkcg: allocate struct blkcg_gq outside request queue spinlock
Date 2017-03-27 20:40 +0200
Message-ID <tpHIB-3SI-13@gated-at.bofh.it> (permalink)
References <tpe3T-773-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sun, Mar 26, 2017 at 3:54 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> Is an unlock needed before line 848?  Or does blkg_lookup_check take care
> of it?

Unlock is not needed. On success, function returns with locks held.
It is documented at line 805:

"... This function returns with RCU read
 * lock and queue lock held and must be paired with blkg_conf_finish()."

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [PATCH] blkcg: allocate struct blkcg_gq outside request queue  spinlock Julia Lawall <julia.lawall@lip6.fr> - 2017-03-26 13:00 +0200
  Re: [PATCH] blkcg: allocate struct blkcg_gq outside request queue spinlock Tahsin Erdogan <tahsin@google.com> - 2017-03-27 20:40 +0200

csiph-web