Re: [PATCH v2 3/3] Input: qt1070 - Add OF device ID table

Path	csiph.com!1.us.feeder.erje.net!2.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!news2.arglkargh.de!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/3] Input: qt1070 - Add OF device ID table
Date	Mon, 27 Mar 2017 17:20:02 +0200
Message-ID	<tpEB4-1AA-9@gated-at.bofh.it> (permalink)
References	<tdGoV-37i-7@gated-at.bofh.it> <tdGoW-37i-17@gated-at.bofh.it> <togr7-6L0-1@gated-at.bofh.it> <toiMi-8kl-17@gated-at.bofh.it>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	41
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
X-Original-Date	Mon, 27 Mar 2017 11:16:31 -0400
X-Original-Message-ID	<544a9efa-a9b5-326e-4930-b185ab51644c@osg.samsung.com>
X-Original-References	<20170222144005.23447-1-javier@osg.samsung.com> <20170222144005.23447-3-javier@osg.samsung.com> <387639b5-01f4-2ba7-3065-5679571c08db@osg.samsung.com> <20170323214559.GB11818@dtor-ws>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1609940

Show key headers only | View raw

Hello Dmitry,

On 03/23/2017 06:45 PM, Dmitry Torokhov wrote:
> On Thu, Mar 23, 2017 at 04:14:56PM -0300, Javier Martinez Canillas wrote:
>> Hello Dmitry,
>>
>> On 02/22/2017 11:40 AM, Javier Martinez Canillas wrote:
>>> The driver doesn't have a struct of_device_id table but supported devices
>>> are registered via Device Trees. This is working on the assumption that a
>>> I2C device registered via OF will always match a legacy I2C device ID and
>>> that the MODALIAS reported will always be of the form i2c:<device>.
>>>
>>> But this could change in the future so the correct approach is to have an
>>> OF device ID table if the devices are registered via OF.
>>>
>>> The compatible strings don't have a vendor prefix because that's how it's
>>> used currently, and changing this will be a Device Tree ABI break.
>>>
>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>> ---
>>>
>>
>> What's your decision about this patch series?
> 
> OK, I queued them for -next. Could you also make a patch to update

Great, thanks a lot!

> binding docs for silead?
> 

Of course, I will.

> Thanks!
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 3/3] Input: qt1070 - Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-23 20:20 +0100
  Re: [PATCH v2 3/3] Input: qt1070 - Add OF device ID table Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-23 22:50 +0100
    Re: [PATCH v2 3/3] Input: qt1070 - Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-27 17:20 +0200

csiph-web