Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1607820 > unrolled thread
| Started by | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| First post | 2017-03-23 20:20 +0100 |
| Last post | 2017-03-27 17:20 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2 3/3] Input: qt1070 - Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-23 20:20 +0100
Re: [PATCH v2 3/3] Input: qt1070 - Add OF device ID table Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-03-23 22:50 +0100
Re: [PATCH v2 3/3] Input: qt1070 - Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-03-27 17:20 +0200
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2017-03-23 20:20 +0100 |
| Subject | Re: [PATCH v2 3/3] Input: qt1070 - Add OF device ID table |
| Message-ID | <togr7-6L0-1@gated-at.bofh.it> |
Hello Dmitry, On 02/22/2017 11:40 AM, Javier Martinez Canillas wrote: > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID and > that the MODALIAS reported will always be of the form i2c:<device>. > > But this could change in the future so the correct approach is to have an > OF device ID table if the devices are registered via OF. > > The compatible strings don't have a vendor prefix because that's how it's > used currently, and changing this will be a Device Tree ABI break. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > --- > What's your decision about this patch series? Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
[toc] | [next] | [standalone]
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2017-03-23 22:50 +0100 |
| Message-ID | <toiMi-8kl-17@gated-at.bofh.it> |
| In reply to | #1607820 |
On Thu, Mar 23, 2017 at 04:14:56PM -0300, Javier Martinez Canillas wrote: > Hello Dmitry, > > On 02/22/2017 11:40 AM, Javier Martinez Canillas wrote: > > The driver doesn't have a struct of_device_id table but supported devices > > are registered via Device Trees. This is working on the assumption that a > > I2C device registered via OF will always match a legacy I2C device ID and > > that the MODALIAS reported will always be of the form i2c:<device>. > > > > But this could change in the future so the correct approach is to have an > > OF device ID table if the devices are registered via OF. > > > > The compatible strings don't have a vendor prefix because that's how it's > > used currently, and changing this will be a Device Tree ABI break. > > > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > > --- > > > > What's your decision about this patch series? OK, I queued them for -next. Could you also make a patch to update binding docs for silead? Thanks! -- Dmitry
[toc] | [prev] | [next] | [standalone]
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2017-03-27 17:20 +0200 |
| Message-ID | <tpEB4-1AA-9@gated-at.bofh.it> |
| In reply to | #1607959 |
Hello Dmitry, On 03/23/2017 06:45 PM, Dmitry Torokhov wrote: > On Thu, Mar 23, 2017 at 04:14:56PM -0300, Javier Martinez Canillas wrote: >> Hello Dmitry, >> >> On 02/22/2017 11:40 AM, Javier Martinez Canillas wrote: >>> The driver doesn't have a struct of_device_id table but supported devices >>> are registered via Device Trees. This is working on the assumption that a >>> I2C device registered via OF will always match a legacy I2C device ID and >>> that the MODALIAS reported will always be of the form i2c:<device>. >>> >>> But this could change in the future so the correct approach is to have an >>> OF device ID table if the devices are registered via OF. >>> >>> The compatible strings don't have a vendor prefix because that's how it's >>> used currently, and changing this will be a Device Tree ABI break. >>> >>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> >>> --- >>> >> >> What's your decision about this patch series? > > OK, I queued them for -next. Could you also make a patch to update Great, thanks a lot! > binding docs for silead? > Of course, I will. > Thanks! > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web