Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1609819
| Path | csiph.com!1.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM |
| Date | Mon, 27 Mar 2017 15:20:03 +0200 |
| Message-ID | <tpCIX-cb-29@gated-at.bofh.it> (permalink) |
| References | <tnOEz-37h-41@gated-at.bofh.it> <tnOXU-3fe-13@gated-at.bofh.it> <tpCzf-8vt-9@gated-at.bofh.it> |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | NeoMutt/20170113 (1.7.2) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 38 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Claudiu Beznea <claudiu.beznea@microchip.com>, thierry.reding@gmail.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nicolas.ferre@microchip.com, cristian.birsan@microchip.com, andrei.pistirica@microchip.com, tudor.ambarus@microchip.com, eugen.hristev@microchip.com |
| X-Original-Date | Mon, 27 Mar 2017 15:15:30 +0200 |
| X-Original-Message-ID | <20170327131530.ifexyrgrp5egtbtr@piout.net> |
| X-Original-References | <1490189375-20384-1-git-send-email-claudiu.beznea@microchip.com> <1490189375-20384-2-git-send-email-claudiu.beznea@microchip.com> <20170327150237.69d8523f@bbrezillon> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1609819 |
Show key headers only | View raw
On 27/03/2017 at 15:02:37 +0200, Boris Brezillon wrote:
> Hi Claudiu,
>
> On Wed, 22 Mar 2017 15:29:34 +0200
> Claudiu Beznea <claudiu.beznea@microchip.com> wrote:
>
> > static const struct platform_device_id atmel_pwm_devtypes[] = {
> > {
> > .name = "at91sam9rl-pwm",
> > - .driver_data = (kernel_ulong_t)&atmel_pwm_data_v1,
> > + .driver_data = (kernel_ulong_t)&atmel_pwm_regs_v1,
> > }, {
> > .name = "sama5d3-pwm",
> > - .driver_data = (kernel_ulong_t)&atmel_pwm_data_v2,
> > + .driver_data = (kernel_ulong_t)&atmel_pwm_regs_v2,
> > }, {
> > /* sentinel */
> > },
>
> Unrelated to this series, but can you prepare a patch to get rid of
> this platform id table (AT91 platforms have completely switched to DT
> for quite some time now).
>
Please, don't until AVR32 is gone.
> You can also get rid of the "if (pdev->dev.of_node)" condition in
> atmel_pwm_probe() since it's guaranteed to be true, otherwise the
> ->probe() method wouldn't be called.
>
> Thanks,
>
> Boris
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 0/2] switch to atomic PWM Claudiu Beznea <claudiu.beznea@microchip.com> - 2017-03-22 14:40 +0100
[PATCH v3 2/2] drivers: pwm: pwm-atmel: enable PWM on sama5d2 Claudiu Beznea <claudiu.beznea@microchip.com> - 2017-03-22 15:00 +0100
Re: [PATCH v3 2/2] drivers: pwm: pwm-atmel: enable PWM on sama5d2 Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-27 15:10 +0200
[PATCH v3 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM Claudiu Beznea <claudiu.beznea@microchip.com> - 2017-03-22 15:00 +0100
Re: [PATCH v3 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-27 15:00 +0200
Re: [PATCH v3 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-27 15:10 +0200
Re: [PATCH v3 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-03-27 15:20 +0200
Re: [PATCH v3 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM m18063 <Claudiu.Beznea@microchip.com> - 2017-03-27 16:20 +0200
Re: [PATCH v3 0/2] switch to atomic PWM Thierry Reding <thierry.reding@gmail.com> - 2017-04-06 16:40 +0200
csiph-web