Re: [PATCH v3 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM
Date	2017-03-27 15:20 +0200
Message-ID	<tpCIX-cb-29@gated-at.bofh.it> (permalink)
References	<tnOEz-37h-41@gated-at.bofh.it> <tnOXU-3fe-13@gated-at.bofh.it> <tpCzf-8vt-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 27/03/2017 at 15:02:37 +0200, Boris Brezillon wrote:
> Hi Claudiu,
> 
> On Wed, 22 Mar 2017 15:29:34 +0200
> Claudiu Beznea <claudiu.beznea@microchip.com> wrote:
> 
> >  static const struct platform_device_id atmel_pwm_devtypes[] = {
> >  	{
> >  		.name = "at91sam9rl-pwm",
> > -		.driver_data = (kernel_ulong_t)&atmel_pwm_data_v1,
> > +		.driver_data = (kernel_ulong_t)&atmel_pwm_regs_v1,
> >  	}, {
> >  		.name = "sama5d3-pwm",
> > -		.driver_data = (kernel_ulong_t)&atmel_pwm_data_v2,
> > +		.driver_data = (kernel_ulong_t)&atmel_pwm_regs_v2,
> >  	}, {
> >  		/* sentinel */
> >  	},
> 
> Unrelated to this series, but can you prepare a patch to get rid of
> this platform id table (AT91 platforms have completely switched to DT
> for quite some time now).
> 

Please, don't until AVR32 is gone.

> You can also get rid of the "if (pdev->dev.of_node)" condition in
> atmel_pwm_probe() since it's guaranteed to be true, otherwise the
> ->probe() method wouldn't be called.
> 
> Thanks,
> 
> Boris

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Thread

[PATCH v3 0/2] switch to atomic PWM Claudiu Beznea <claudiu.beznea@microchip.com> - 2017-03-22 14:40 +0100
  [PATCH v3 2/2] drivers: pwm: pwm-atmel: enable PWM on sama5d2 Claudiu Beznea <claudiu.beznea@microchip.com> - 2017-03-22 15:00 +0100
    Re: [PATCH v3 2/2] drivers: pwm: pwm-atmel: enable PWM on sama5d2 Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-27 15:10 +0200
  [PATCH v3 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM Claudiu Beznea <claudiu.beznea@microchip.com> - 2017-03-22 15:00 +0100
    Re: [PATCH v3 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-27 15:00 +0200
    Re: [PATCH v3 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-27 15:10 +0200
      Re: [PATCH v3 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-03-27 15:20 +0200
        Re: [PATCH v3 1/2] drivers: pwm: pwm-atmel: switch to atomic PWM m18063 <Claudiu.Beznea@microchip.com> - 2017-03-27 16:20 +0200
  Re: [PATCH v3 0/2] switch to atomic PWM Thierry Reding <thierry.reding@gmail.com> - 2017-04-06 16:40 +0200

csiph-web