[PATCH v3 1/2] net: phy: Fix PHY AN done state machine for interrupt driven PHYs

Path	csiph.com!fu-berlin.de!bofh.it!news.nic.it!robomod
From	Roger Quadros <rogerq@ti.com>
Newsgroups	linux.kernel
Subject	[PATCH v3 1/2] net: phy: Fix PHY AN done state machine for interrupt driven PHYs
Date	Mon, 27 Mar 2017 14:10:01 +0200
Message-ID	<tpBDb-7On-5@gated-at.bofh.it> (permalink)
References	<tnMjo-1pY-33@gated-at.bofh.it> <tnMjo-1pY-31@gated-at.bofh.it>
X-Original-To	<f.fainelli@gmail.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1490615954; bh=KSHv4qwllmheWKo8ICa2UsH5JTqopxP6sl2fgje0y54=; h=Subject:To:References:CC:From:Date:In-Reply-To; b=QAJQCyj8dqmWKsgxchrlYSNHAhCfTP5E2N+C4MaODbmBKiQH9Bg/A9+PrnWqUcaIv fI7vs4fflp0QX4Q0oR/7ud9hc1v4mbLWgsA715/Ze6UsKxTKKSuTFETlnbm0YyT+Bg VevmEbhgzgdM/l2CSKRhoTTpfzSiM2fl80vdJ4cE=
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0
MIME-Version	1.0
Content-Type	text/plain; charset="windows-1252"
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	42
Organization	linux.* mail to news gateway
X-Original-Cc	<andrew@lunn.ch>, <davem@davemloft.net>, <kyle.roeschley@ni.com>, <nsekhar@ti.com>, <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>, "stable # v4 . 9+" <stable@vger.kernel.org>, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, <rogerq@ti.com>
X-Original-Date	Mon, 27 Mar 2017 14:59:04 +0300
X-Original-Message-ID	<078917ad-77a1-a722-1688-6203ae183a46@ti.com>
X-Original-References	<1490180524-28675-1-git-send-email-rogerq@ti.com> <1490180524-28675-2-git-send-email-rogerq@ti.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1609761

Show key headers only | View raw

The Ethernet link on an interrupt driven PHY was not coming up if the
Ethernet cable was plugged before the Ethernet interface was brought up.

The PHY state machine seems to be stuck from RUNNING to AN state
with no new interrupts from the PHY. So it doesn't know when the
PHY Auto-negotiation has been completed and doesn't transition to RUNNING
state with ANEG done thus netif_carrier_on() is never called.

NOTE: genphy_config_aneg() will not restart PHY Auto-negotiation of
advertisement parameters didn't change.

Fix this by scheduling the PHY state machine in phy_start_aneg().
There is no way of knowing in phy.c whether auto-negotiation was
restarted or not by the PHY driver so we just wait for the next
poll/interrupt to update the PHY state machine.

Fixes: 3c293f4e08b5 ("net: phy: Trigger state machine on state change and not polling.")
Cc: stable <stable@vger.kernel.org> # v4.9+
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
v3: Fix typo in commit message

 drivers/net/phy/phy.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 1be69d8..49dedf8 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -630,6 +630,10 @@ int phy_start_aneg(struct phy_device *phydev)
 
 out_unlock:
 	mutex_unlock(&phydev->lock);
+	if (!err && phy_interrupt_is_valid(phydev))
+		queue_delayed_work(system_power_efficient_wq,
+				   &phydev->state_queue, HZ);
+
 	return err;
 }
 EXPORT_SYMBOL(phy_start_aneg);
-- 
2.7.4

Thread

[PATCH v2 1/2] net: phy: Fix PHY AN done state machine for interrupt driven PHYs Roger Quadros <rogerq@ti.com> - 2017-03-22 12:10 +0100
  Re: [PATCH v2 1/2] net: phy: Fix PHY AN done state machine for  interrupt driven PHYs Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-03-23 11:00 +0100
    Re: [PATCH v2 1/2] net: phy: Fix PHY AN done state machine for  interrupt driven PHYs Roger Quadros <rogerq@ti.com> - 2017-03-27 14:00 +0200
  [PATCH v3 1/2] net: phy: Fix PHY AN done state machine for interrupt  driven PHYs Roger Quadros <rogerq@ti.com> - 2017-03-27 14:10 +0200
    Re: [PATCH v3 1/2] net: phy: Fix PHY AN done state machine for  interrupt driven PHYs Roger Quadros <rogerq@ti.com> - 2017-03-28 12:10 +0200
    RE: [PATCH v3 1/2] net: phy: Fix PHY AN done state machine for  interrupt driven PHYs Madalin-Cristian Bucur <madalin.bucur@nxp.com> - 2017-03-30 15:10 +0200
    Re: [PATCH v3 1/2] net: phy: Fix PHY AN done state machine for  interrupt driven PHYs Florian Fainelli <f.fainelli@gmail.com> - 2017-03-30 22:10 +0200
      Re: [PATCH v3 1/2] net: phy: Fix PHY AN done state machine for  interrupt driven PHYs Roger Quadros <rogerq@ti.com> - 2017-03-31 11:30 +0200

csiph-web