Re: [PATCH v2 1/2] net: phy: Fix PHY AN done state machine for interrupt driven PHYs

From	Roger Quadros <rogerq@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] net: phy: Fix PHY AN done state machine for interrupt driven PHYs
Date	2017-03-27 14:00 +0200
Message-ID	<tpBtx-7vp-27@gated-at.bofh.it> (permalink)
References	<tnMjo-1pY-33@gated-at.bofh.it> <tnMjo-1pY-31@gated-at.bofh.it> <to7Hb-q5-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 23/03/17 11:52, Sergei Shtylyov wrote:
> Hello!
> 
> On 3/22/2017 2:02 PM, Roger Quadros wrote:
> 
>> he ethernet link on an interrupt driven PHY was not coming up if the
> 
>    s/he/The/?
> 
>> ethernet cable was plugged before the ethernet interface was brought up.
> 
>    Also, my spell checker trips on "ethernet", perhaps should be capitalized?

Thanks. I'll fix both issues.

> 
>> The PHY state machine seems to be stuck from RUNNING to AN state
>> with no new interrupts from the PHY. So it doesn't know when the
>> PHY Auto-negotiation has been completed and doesn't transition to RUNNING
>> state with ANEG done thus netif_carrier_on() is never called.
>>
>> NOTE: genphy_config_aneg() will not restart PHY Auto-negotiation of
>> advertisement parameters didn't change.
>>
>> Fix this by scheduling the PHY state machine in phy_start_aneg().
>>
>> Fixes: 3c293f4e08b5 ("net: phy: Trigger state machine on state change and not polling.")
>> Cc: stable <stable@vger.kernel.org> # v4.9+
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
> [...]
> 
> MBR, Sergei
> 

cheers,
-roger

Thread

[PATCH v2 1/2] net: phy: Fix PHY AN done state machine for interrupt driven PHYs Roger Quadros <rogerq@ti.com> - 2017-03-22 12:10 +0100
  Re: [PATCH v2 1/2] net: phy: Fix PHY AN done state machine for  interrupt driven PHYs Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-03-23 11:00 +0100
    Re: [PATCH v2 1/2] net: phy: Fix PHY AN done state machine for  interrupt driven PHYs Roger Quadros <rogerq@ti.com> - 2017-03-27 14:00 +0200
  [PATCH v3 1/2] net: phy: Fix PHY AN done state machine for interrupt  driven PHYs Roger Quadros <rogerq@ti.com> - 2017-03-27 14:10 +0200
    Re: [PATCH v3 1/2] net: phy: Fix PHY AN done state machine for  interrupt driven PHYs Roger Quadros <rogerq@ti.com> - 2017-03-28 12:10 +0200
    RE: [PATCH v3 1/2] net: phy: Fix PHY AN done state machine for  interrupt driven PHYs Madalin-Cristian Bucur <madalin.bucur@nxp.com> - 2017-03-30 15:10 +0200
    Re: [PATCH v3 1/2] net: phy: Fix PHY AN done state machine for  interrupt driven PHYs Florian Fainelli <f.fainelli@gmail.com> - 2017-03-30 22:10 +0200
      Re: [PATCH v3 1/2] net: phy: Fix PHY AN done state machine for  interrupt driven PHYs Roger Quadros <rogerq@ti.com> - 2017-03-31 11:30 +0200

csiph-web