Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1609740
| From | Jan Kiszka <jan.kiszka@siemens.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 0/7] efi: Enhance capsule loader to support signed Quark images |
| Date | 2017-03-27 13:10 +0200 |
| Message-ID | <tpAH8-75T-11@gated-at.bofh.it> (permalink) |
| References | <toBlT-4TS-1@gated-at.bofh.it> <tpAnM-6J9-33@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 2017-03-27 12:29, Bryan O'Donoghue wrote: > > > On 24/03/17 17:34, Jan Kiszka wrote: >> This addresses the review feedback provided on round 1, specifically >> - refactored queue to keep the Quark mess in >> - only check for CSH on Quark CPUs >> - added some smaller cleanups of the capsule loader >> - documented capsule header / linked to original code >> >> See last patch for the background of the series. >> >> The series has been tested on the Galileo Gen2, to exclude regressions, >> with a firmware.cap with AND without security header and the SIMATIC >> IOT2040 which requires the header because of its mandatory secure boot. >> >> Jan >> >> Jan Kiszka (7): >> efi/capsule: Fix return code on failing kmap/vmap >> efi/capsule: Remove pr_debug on ENOMEM or EFAULT >> efi/capsule: Clean up pr_err/info messages >> efi/capsule: Adjust return type of efi_capsule_setup_info >> efi/capsule: Prepare for loading images with security header >> efi/capsule: Factor out overloadable efi_capsule_identify_image >> efi/capsule: Add support for Quark security header >> >> arch/x86/platform/efi/quirks.c | 95 ++++++++++++++++++++++++ >> drivers/firmware/efi/capsule-loader.c | 136 >> +++++++++++++++++++--------------- >> drivers/firmware/efi/capsule.c | 21 +++++- >> include/linux/efi.h | 19 +++++ >> 4 files changed, 208 insertions(+), 63 deletions(-) >> > > BTW, > > Thanks for taking the time to remove the __func__ stuff all over the place. > > I'll try to test this out for you. I found that the current BSP Intel is > releasing has some sort of GUI that downloads an image to a board (which > completely fails for me on the Galileo I have)... not sure if you have > different results with the stuff from the Intel website but it's > non-functional for me :( I found the Galileo capsules *.cap in the jar archives of the Galileo firmware update packages, and they work. > > I'd like to suggest to you adding something to Documentation describing > how to load and trigger a capsule update. For example on Quark you need > to use the EFI reset method to cause capsule update to work. cat /path/to/capsule.cap > /dev/efi_capsule_loader The reset method is auto-adjusted by the kernel when an update is pending. So firmware update is now seriously simple. But I can write a 2 or 3-lines readme if it's preferred. > > Could you add a patch to your series for Documentation detailing: > > 1. Entry criteria (needing to boot in EFI reset mode) > 1. Description of loading a capsule > 3. Description of triggering the update (reboot) > 4. Verifying the update succeeded (actually is this possible right now?) dmidecode -> check BIOS version information (vendor-specific) Jan
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/7] efi: Enhance capsule loader to support signed Quark images Jan Kiszka <jan.kiszka@siemens.com> - 2017-03-24 18:40 +0100
[PATCH v2 4/7] efi/capsule: Adjust return type of efi_capsule_setup_info Jan Kiszka <jan.kiszka@siemens.com> - 2017-03-24 18:40 +0100
Re: [PATCH v2 4/7] efi/capsule: Adjust return type of efi_capsule_setup_info Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-03-24 19:50 +0100
[PATCH v2 6/7] efi/capsule: Factor out overloadable efi_capsule_identify_image Jan Kiszka <jan.kiszka@siemens.com> - 2017-03-24 18:40 +0100
[PATCH v2 5/7] efi/capsule: Prepare for loading images with security header Jan Kiszka <jan.kiszka@siemens.com> - 2017-03-24 18:40 +0100
Re: [PATCH v2 5/7] efi/capsule: Prepare for loading images with security header Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-24 21:30 +0100
Re: [PATCH v2 5/7] efi/capsule: Prepare for loading images with security header Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-03-28 16:00 +0200
Re: [PATCH v2 5/7] efi/capsule: Prepare for loading images with security header Jan Kiszka <jan.kiszka@siemens.com> - 2017-03-28 17:20 +0200
Re: [PATCH v2 5/7] efi/capsule: Prepare for loading images with security header Jan Kiszka <jan.kiszka@siemens.com> - 2017-03-28 17:50 +0200
Re: [PATCH v2 5/7] efi/capsule: Prepare for loading images with security header Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-03-28 18:00 +0200
Re: [PATCH v2 5/7] efi/capsule: Prepare for loading images with security header Jan Kiszka <jan.kiszka@siemens.com> - 2017-03-28 18:30 +0200
Re: [PATCH v2 5/7] efi/capsule: Prepare for loading images with security header Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-03-28 19:30 +0200
Re: [PATCH v2 5/7] efi/capsule: Prepare for loading images with security header Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-03-28 19:30 +0200
Re: [PATCH v2 5/7] efi/capsule: Prepare for loading images with security header Jan Kiszka <jan.kiszka@siemens.com> - 2017-03-30 11:10 +0200
Re: [PATCH v2 5/7] efi/capsule: Prepare for loading images with security header Jan Kiszka <jan.kiszka@siemens.com> - 2017-04-04 19:50 +0200
[PATCH v2 3/7] efi/capsule: Clean up pr_err/info messages Jan Kiszka <jan.kiszka@siemens.com> - 2017-03-24 18:40 +0100
Re: [PATCH v2 3/7] efi/capsule: Clean up pr_err/info messages Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-03-24 19:20 +0100
[PATCH v2 2/7] efi/capsule: Remove pr_debug on ENOMEM or EFAULT Jan Kiszka <jan.kiszka@siemens.com> - 2017-03-24 18:40 +0100
Re: [PATCH v2 2/7] efi/capsule: Remove pr_debug on ENOMEM or EFAULT Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-03-24 19:20 +0100
[PATCH v2 1/7] efi/capsule: Fix return code on failing kmap/vmap Jan Kiszka <jan.kiszka@siemens.com> - 2017-03-24 18:40 +0100
Re: [PATCH v2 1/7] efi/capsule: Fix return code on failing kmap/vmap Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-03-24 19:20 +0100
[PATCH v2 7/7] efi/capsule: Add support for Quark security header Jan Kiszka <jan.kiszka@siemens.com> - 2017-03-24 18:40 +0100
Re: [PATCH v2 7/7] efi/capsule: Add support for Quark security header Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-24 21:40 +0100
Re: [PATCH v2 0/7] efi: Enhance capsule loader to support signed Quark images Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-24 21:50 +0100
Re: [PATCH v2 0/7] efi: Enhance capsule loader to support signed Quark images Jan Kiszka <jan.kiszka@siemens.com> - 2017-03-27 13:30 +0200
Re: [PATCH v2 0/7] efi: Enhance capsule loader to support signed Quark images Bryan O'Donoghue <pure.logic@nexus-software.ie> - 2017-03-27 12:50 +0200
Re: [PATCH v2 0/7] efi: Enhance capsule loader to support signed Quark images Jan Kiszka <jan.kiszka@siemens.com> - 2017-03-27 13:10 +0200
Re: [PATCH v2 0/7] efi: Enhance capsule loader to support signed Quark images Bryan O'Donoghue <pure.logic@nexus-software.ie> - 2017-03-28 02:50 +0200
csiph-web